-
Notifications
You must be signed in to change notification settings - Fork 343
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add eigen version from main. #3251
Conversation
Hello @bazelbuild/bcr-maintainers, modules without existing maintainers (eigen) have been updated in this PR. Please review the changes. |
The version format change is concerning, assuming there is a 3.5 coming out later, |
@meteorcloudy I wasn't sure myself how to version it. Do you have a better suggestion? 4.0 should come some time as well, but not much work is going on according to https://gitlab.com/libeigen/eigen/-/issues/2699, https://gitlab.com/libeigen/eigen/-/issues/2845, and https://gitlab.com/libeigen/eigen/-/issues/2848. |
Considering the latest released version is 3 years old, and the new version is in discussion but no actual plans or dates, we are blocked since our tests depend on a newer version and are failing on an older version. For now, I don't see a better way than to suggest @feuerste to use the date from when HEAD was cut (i.e. today) to create this. @feuerste already shared a few issue discussions based on which I suggested to cut from HEAD to get in the newer features that we depend on. |
Indeed, it's a bit tricky, but to be future proof, maybe we can use something like: |
ddf1f52
to
7c2ecf9
Compare
Please also fix the directory name |
Head branch was pushed to by a user without write access
7c2ecf9
to
76330f3
Compare
Require module maintainers' approval for newly pushed changes.
Thanks for your review and suggestions @meteorcloudy ! |
Np, one more fix needed ;)
|
Version 3.4.0 is 3 years old. This version pulls in all the functionality added throughout the last years.
Head branch was pushed to by a user without write access
76330f3
to
7094ba9
Compare
Require module maintainers' approval for newly pushed changes.
Version 3.4.0 is 3 years old. This version pulls
in all the functionality added throughout the last years.