Skip to content

Commit

Permalink
Remove //test:for_bazel_test from global for_bazel_tests (#240)
Browse files Browse the repository at this point in the history
If the test/ package is invalid we still shouldn't fail rules_apple.
This can happen when bazel deletes an API that we use only in tests in
this repo
  • Loading branch information
keith authored Aug 4, 2023
1 parent 557daa2 commit 361ea63
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 2 deletions.
1 change: 0 additions & 1 deletion BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,6 @@ filegroup(
"//crosstool:for_bazel_tests",
"//lib:for_bazel_tests",
"//rules:for_bazel_tests",
"//test:for_bazel_tests",
"//tools:for_bazel_tests",
],
# Exposed publicly just so other rules can use this if they set up
Expand Down
2 changes: 1 addition & 1 deletion test/BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ filegroup(
name = "for_bazel_tests",
testonly = True,
srcs = glob(["**"]),
visibility = ["//:__pkg__"],
visibility = ["//test/shell:__pkg__"],
)

cc_binary(
Expand Down
1 change: 1 addition & 0 deletions test/shell/BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ filegroup(
name = "for_bazel_tests",
testonly = True,
srcs = [
"//test:for_bazel_tests",
"@build_bazel_apple_support//:for_bazel_tests",
],
)
Expand Down

0 comments on commit 361ea63

Please sign in to comment.