-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upload binary release artifact per commit #262
Conversation
This PR adds the ability to upload release artifact via XCHammer's github CI. On each build, we upload the binary release artifact `xchammer.zip` which can be pulled into a bazel `WORKSPACE` with `http_archive` and then used as expected. At first, I'd considered creating a release on each commit but that has a few complexities in github actions e.g. can't create a release w/o a tag, and would end up annoying watchers of the repository with a release email on each commit landed. Perhaps there could be a better way to navigate to these artifact URLs in the github UI longer term.
What are the tradeoffs between doing this per-commit versus with explicit versions and tagged releases? |
@jparise I don't think the 2 are mutually exclusive and it's useful to have a per commit and per release artifact. When folks are running on XCHammer has a lot of minor but necessary commits. Its hard to draw a line in what a release would be as builds are often backwards and forwards compatible with Bazel and rules. IMO if there's a commit landing into master or even a PR someone will need the build! Even in rare some cases, I need to pull a XCHammer PR into I'm not opposed to cutting releases more often or we have a large milestone e.g. tested Bazel version. If we only had a per release artifact we'd then need to create a lot of releases to pull the artifact
Only release
No release / only per commit
Both
|
0d3aff2
to
4dc05e6
Compare
This reverts commit 4dc05e6.
24e81a3
to
44b294e
Compare
5a0b8b8
to
d0fc3cb
Compare
The github actions API doesn't play well with per commit artifacts. For now we create a release when pushing a tag. Consuming the per commit artifacts w/o the github actions API is blocked by this: actions/upload-artifact#50
I've additionally added the ability to upload a release artifact when pushing a tag v* The github actions API doesn't play well with per commit artifacts. For now we create a release when pushing a tag. Consuming the per commit artifacts directly with Bazel w/o the github actions API is blocked by this: actions/upload-artifact#50 I've added a detailed description of how to create a binary check in or local repository using the per commit artifact to the README. |
b849ae9
to
004ea8e
Compare
This PR adds the ability to upload release artifact via XCHammer's github
CI and it creates a release when pushing a tag to v*
The github actions API doesn't play well with per commit artifacts. For
now we create a release when pushing a tag.
Consuming the per commit artifacts w/o the github actions API is blocked
by this: actions/upload-artifact#50