Add a dependency for rules_cc to MODULE.bazel
#56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`rules_perl` requires the `rules_cc` repository to be present: https://github.com/bazelbuild/rules_perl/blob/022b8daf2bb4836ac7a50e4a1d8ea056a3e1e403/perl/perl.bzl#L19 While this isn't an issue when running the examples for this repo (i.e. `bazel build --enable_bzlmod //examples/hello_world:hello_world` works fine — rules_cc appears to be implicitly added to the repo mapping for the current root module's repo), when depending on `rules_perl` from another module this becomes an issue. Even if the dependent pulls in the `rules_cc` module, `rules_cc` will not be visible in `rules_perl`'s mapping unless `rules_perl` also declares a dependency on it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rules_perlrequires therules_ccrepository to be present: https://github.com/bazelbuild/rules_perl/blob/022b8daf2bb4836ac7a50e4a1d8ea056a3e1e403/perl/perl.bzl#L19While this isn't an issue when running the examples for this repo (i.e.
bazel build --enable_bzlmod //examples/hello_world:hello_worldworks fine — rules_cc appears to be implicitly added to the repo mapping for the current root module's repo), when depending onrules_perlfrom another module this becomes an issue.Even if the dependent pulls in the
rules_ccmodule,rules_ccwill not be visible inrules_perl's mapping unlessrules_perlalso declares a dependency on it.