Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ts_proto_library to use ProtoInfo. #925

Merged
merged 1 commit into from
Jul 20, 2019

Conversation

lberki
Copy link
Contributor

@lberki lberki commented Jul 19, 2019

Instead of the deprecated .proto. provider .

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature (please, look at the "Scope of the project" section in the README.md file)
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

ts_proto_library depends on the .proto. provider which is going to be removed in Bazel 1.0:
bazelbuild/bazel#7152

Issue Number: bazelbuild/bazel#7152

What is the new behavior?

It uses the new ProtoInfo provider.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Instead of the deprecated .proto. provider .
Copy link
Collaborator

@alexeagle alexeagle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants