Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node.js toolchain support #898

Merged

Conversation

gregmagolan
Copy link
Collaborator

@gregmagolan gregmagolan commented Jul 4, 2019

Replaces #827

@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

ℹ️ Googlers: Go here for more info.

@gregmagolan gregmagolan force-pushed the initial-toolchain-support branch from e7b21d5 to 5d5a139 Compare July 5, 2019 04:45
@gregmagolan gregmagolan force-pushed the initial-toolchain-support branch from 5d5a139 to 596018a Compare July 5, 2019 04:48
@gregmagolan gregmagolan changed the title CI Test: Initial toolchain support Node.js toolchain support Jul 5, 2019
@alexeagle alexeagle added cla: yes and removed cla: no labels Jul 9, 2019
@googlebot
Copy link

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

@alexeagle alexeagle merged commit aeff5e7 into bazel-contrib:master Jul 9, 2019
@gregmagolan gregmagolan mentioned this pull request Jul 15, 2019
12 tasks
@vielmetti vielmetti mentioned this pull request Nov 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants