Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(typescript): collect coverage in ts_project #2763

Merged
merged 1 commit into from
Jun 11, 2021

Conversation

subnova
Copy link
Contributor

@subnova subnova commented Jun 10, 2021

Fixes #2762

PR Checklist

Please check if your PR fulfills the following requirements:

Any advice on how to create a test for this appreciated.

  • Tests for the changes have been added (for bug fixes / features)
  • [ n/a] Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • [ x] Bugfix
  • Feature (please, look at the "Scope of the project" section in the README.md file)
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Coverage reports are not generated when tests are built using ts_project

Issue Number: #2762

What is the new behavior?

Coverage reports are generated

Does this PR introduce a breaking change?

  • Yes
  • [ x] No

Other information

@subnova
Copy link
Contributor Author

subnova commented Jun 11, 2021

Hi, I see there are some required checks waiting here. Is there something I need to do to trigger those?

@alexeagle
Copy link
Collaborator

Thanks for the ping, I'm not sure why the CircleCI didn't pick this up, but that's for coverage in actual browsers and I'm confident in this change without that.

@alexeagle alexeagle merged commit 045f91a into bazel-contrib:stable Jun 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Coverage not generated with ts_project
2 participants