fix: forward srcs, deps and visibility of dummy_bzl_library to the filegroup when publishing #2430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…legroup when publishing
mattem
requested review from
alexeagle,
gregmagolan and
soldair
as code owners
alexeagle
approved these changes
Jan 29, 2021
Kernald
added a commit
to Kernald/rules_sass
that referenced
this pull request
Aug 19, 2021
bazel-contrib/rules_nodejs#2430 is needed to access rules_nodejs's bzl_library target, which was first included after their 3.0.0 release.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns the name-only filegroup into a filegroup with sources in the published output. Visibility and deps are also forwarded.
This would allow downstream rule authors to depend on the
bzltargets insrcsattributes ofbzl_library, without imposing skylib on all users of rules_nodejs.Slack thread context: https://bazelbuild.slack.com/archives/CA31HN1T3/p1611882849199500