Allow for custom rollup config #234
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
June 15, 2018 18:17
|
@kalbasit nice, happy to hear that |
|
@alexeagle This PR makes it easier to use Rollup, is it something you would consider, or is there some other way being worked on or considered? |
|
@Globegitter can you please rebase your PR over master? It looks like one file is conflicting. |
|
New rollup_bundle rule lets you pass rollup.config.js. Should launch with next release |
alexeagle
pushed a commit
to alexeagle/rules_nodejs
that referenced
this pull request
Oct 17, 2020
…azel_rules_typescript_tsc_wrapped_deps//:node_modules BREAKING CHANGE: If you don't have an npm dependency on `@bazel/typescript`, you may be missing libraries like protobufjs which are required at runtime. Run `yarn add -D @bazel/typescript` or `npm install --save-dev @bazel/typescript` to fix. Closes bazel-contrib#234 PiperOrigin-RevId: 206037532
alexeagle
pushed a commit
to alexeagle/rules_nodejs
that referenced
this pull request
Oct 18, 2020
…azel_rules_typescript_tsc_wrapped_deps//:node_modules BREAKING CHANGE: If you don't have an npm dependency on `@bazel/typescript`, you may be missing libraries like protobufjs which are required at runtime. Run `yarn add -D @bazel/typescript` or `npm install --save-dev @bazel/typescript` to fix. Closes bazel-contrib#234 PiperOrigin-RevId: 206037532
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even though the default rollup setup is pretty good and should work for most use cases, I think there are also quite a few use-cases that would want to utilize further rollup plugins (us included) and having to write a custom rule for each of these separate use-cases seems a bit cumbersome. So I came up with a way of providing a custom config without having to write your own rule.
Here one would have to provide their own node_modules, which is a superset of the existing node_modules (have not found a satisfying way to have the nodejs_binary depend on two sets of node_modules). Then one would have to copy the existing
rollup.config.jsand ensure to keep theTMPL_variables in place. It is not quite ideal but imo stil makes it easier than creating a custom rule.This would allow it to quite easily fix #216 and commonjs support mentioned in #137
Also internally we are experimenting with a few different plugins and this makes it easier for us than having to write/modify a custom rule.