WIP: Multiple Node Versions in Single Workspace

[parisholley]

PR Checklist

Please check if your PR fulfills the following requirements:

• Tests for the changes have been added (for bug fixes / features)
• Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

• Bugfix
• Feature (please, look at the "Scope of the project" section in the README.md file)
• Code style update (formatting, local variables)
• Refactoring (no functional changes, no api changes)
• Build related changes
• CI related changes
• Documentation content changes
• Other... Please describe:

What is the current behavior?

Issue Number: #434

What is the new behavior?

User can pass a custom name to node_repositories (allowing multiple node versions at the same time), then the other rules in the project allow setting a customer "node_repository" to point to the custom version.

Does this PR introduce a breaking change?

• Yes
• No

Other information

Submitting this pull as a PR as i'm not all that familiar with bazel and want to get some thought before going all the way down the path of supporting dynamic @nodejs alias names, given there are a quite a few places where the alias is hardedcode and no ctx is available (so some deeper refactoring would be needed).

[googlebot]

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

---

What to do if you already signed the CLA

Individual signers

• It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

• Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
• The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
• The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

[parisholley]

@googlebot I signed it!

[googlebot]

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

[alexeagle]

cool, looks like a good start, thanks for tackling this!

we should have a test somewhere - maybe update an existing e2e or example to use both node 12 and also node 14

[alexeagle]

you can do this in one step - pop returns the element

[alexeagle]

hey @parisholley any update on this one?

[parisholley]

i decided to just upgrade everything to latest node so i stopped work on it

[github-actions]

This Pull Request has been automatically marked as stale because it has not had any activity for 90 days. It will be closed if no further activity occurs in two weeks. Collaborators can add a "cleanup" or "need: discussion" label to keep it open indefinitely. Thanks for your contributions to rules_nodejs!

[github-actions]

This PR was automatically closed because it went two weeks without a reply since it was labeled "Can Close?"