chore: remove old rollup_bundle #1355
Conversation
|
|
You could also remove collect_es6_sources.bzl at this point as angular/angular no longer depends on that either. |
alexeagle
force-pushed
the
rm_rollup_bundle
branch
from
e8ee9ff to
6385baf
Compare
|
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
alexeagle
force-pushed
the
rm_rollup_bundle
branch
from
9b12432 to
7383866
Compare
|
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
BREAKING CHANGE: internal/rollup_bundle rule is removed. see https://github.com/bazelbuild/rules_nodejs/wiki for migration instructions Fixes bazel-contrib#740
This is the current latest version of @angular/bazel and is needed as older versions depended on the legacy rollup_bundle internals in the ng_package rule.
gregmagolan
force-pushed
the
rm_rollup_bundle
branch
from
7383866 to
b428e83
Compare
|
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
|
A Googler has manually verified that the CLAs look good. (Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.) ℹ️ Googlers: Go here for more info. |
BREAKING CHANGE:
internal/rollup_bundle rule is removed. see https://github.com/bazelbuild/rules_nodejs/wiki for migration instructions
Fixes #740