feat(karma): npm peer deps & remove @rules_webtesting//browsers/sauce:chrome-win10 support #1346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gregmagolan
force-pushed
the
karma_peer_deps
branch
3 times, most recently
from
923df59
to
3de6f6a
Compare
…:chrome-win10 support Also cleanup us arguments and doc string for karma_web_test_suite. BREAKING CHANGES: npm karma deps for karma_web_test and karma_web_suite are now peer deps so that the versions used can be chosen by the user. This PR also removes the built-in `@io_bazel_rules_webtesting//browsers/sauce:chrome-win10` saucelabs support. It is not very useful as it only tests a single browser and it difficult to use. In the angular repo, saucelabs support was implemented with a custom karma config using karma_web_test. This is the recommended approach.
gregmagolan
force-pushed
the
karma_peer_deps
branch
from
3de6f6a
to
8f7f32d
Compare
alexeagle
approved these changes
Nov 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Branches off of #1342 which should land first.
Also cleanup us arguments and doc string for karma_web_test_suite.
BREAKING CHANGES:
npm karma deps for karma_web_test and karma_web_suite are now peer deps so that the versions used can be chosen by the user.
This PR also removes the built-in
@io_bazel_rules_webtesting//browsers/sauce:chrome-win10saucelabs support. It is not very useful as it only tests a single browser and it difficult to use. In the angular repo, saucelabs support was implemented with a custom karma config using karma_web_test. This is the recommended approach.