Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(builtin): add a DeclarationInfo provider #1052

Merged
merged 1 commit into from
Aug 24, 2019

Conversation

alexeagle
Copy link
Collaborator

This gives us a principled way for rules to generate and consume TypeScript typings

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature (please, look at the "Scope of the project" section in the README.md file)
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

This gives us a principled way for rules to generate and consume TypeScript typings
@alexeagle alexeagle marked this pull request as ready for review August 23, 2019 23:48
alexeagle added a commit to bazelbuild/rules_typescript that referenced this pull request Aug 24, 2019
…gacy provider

This is the part of removing the legacy providers, per bazelbuild/bazel#7347

Depends on bazel-contrib/rules_nodejs#1052

PiperOrigin-RevId: 265167694
@alexeagle
Copy link
Collaborator Author

Was reviewed in g3 as part of rules_typescript commit

@alexeagle alexeagle merged commit 3d7eb13 into bazel-contrib:master Aug 24, 2019
@alexeagle alexeagle deleted the declaration_info branch August 24, 2019 03:41
alexeagle added a commit to alexeagle/rules_nodejs that referenced this pull request Oct 17, 2020
…gacy provider

This is the part of removing the legacy providers, per bazelbuild/bazel#7347

Depends on bazel-contrib#1052

PiperOrigin-RevId: 265167694
alexeagle added a commit to alexeagle/rules_nodejs that referenced this pull request Oct 18, 2020
…gacy provider

This is the part of removing the legacy providers, per bazelbuild/bazel#7347

Depends on bazel-contrib#1052

PiperOrigin-RevId: 265167694
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants