Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update coursier to v2.1.0-RC6 #868

Merged
merged 1 commit into from
Mar 7, 2023
Merged

Update coursier to v2.1.0-RC6 #868

merged 1 commit into from
Mar 7, 2023

Conversation

cheister
Copy link
Collaborator

@cheister cheister commented Mar 3, 2023 •
edited
Loading

This was tested by running

bazel run @unpinned_maven//:pin              
bazel run @unpinned_json_artifacts_testing//:pin
bazel run @unpinned_manifest_stamp_testing//:pin
bazel run @unpinned_maven_install_in_custom_location//:pin
bazel run @unpinned_policy_pinned_testing//:pin
bazel run @unpinned_regression_testing//:pin
bazel run @unpinned_rules_jvm_external_deps//:pin
  • needs the coursier jar to be uploaded to the google mirror

@cheister cheister requested review from shs96c and jin March 3, 2023 02:33
shs96c
shs96c approved these changes Mar 3, 2023
View reviewed changes
Copy link
Collaborator

@shs96c shs96c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you.

@cheister cheister force-pushed the coursier-v2.1.0-RC6 branch from ab1ffc2 to a14ca8d Compare March 3, 2023 18:57
@cheister
Copy link
Collaborator Author

cheister commented Mar 7, 2023

@jin can you upload coursier to the mirror?

@jin
Copy link
Collaborator

jin commented Mar 7, 2023

Done: https://mirror.bazel.build/coursier_cli/coursier_cli_v2_1_0_RC6.jar

@cheister cheister merged commit 2e92f50 into bazel-contrib:master Mar 7, 2023
@cheister cheister deleted the coursier-v2.1.0-RC6 branch March 7, 2023 16:10
thirtyseven pushed a commit to thirtyseven/rules_jvm_external that referenced this pull request Jun 29, 2023
@cheister @thirtyseven
Update coursier to v2.1.0-RC6 (bazel-contrib#868)
6086cce
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jin jin jin approved these changes

@shs96c shs96c shs96c approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cheister @jin @shs96c