Index service implementations as well as packages #1063
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
illicitonion
requested review from
jin,
Wyverald,
shs96c and
cheister
as code owners
illicitonion
force-pushed
the
service-impls
branch
from
b61cc1a to
9ec8f81
Compare
shs96c
approved these changes
Apr 2, 2024
private/tools/java/com/github/bazelbuild/rules_jvm_external/jar/IndexJar.java
Outdated
Show resolved
Hide resolved
private/tools/java/com/github/bazelbuild/rules_jvm_external/jar/IndexJar.java
Outdated
Show resolved
Hide resolved
tests/com/github/bazelbuild/rules_jvm_external/jar/IndexJarTest.java
Outdated
Show resolved
Hide resolved
tests/com/github/bazelbuild/rules_jvm_external/jar/IndexJarTest.java
Outdated
Show resolved
Hide resolved
I'm going to make it do more indexing.
This can be useful for detecting things like annotation processors, and knowing whether a target represents a java_plugin or just a java_library.
illicitonion
force-pushed
the
service-impls
branch
from
9ec8f81 to
c521941
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This can be useful for detecting things like annotation processors, and
knowing whether a target represents a java_plugin or just a
java_library.