Do not remove LICENSE files when combining jars #1054
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maven_project_jar has a jar combining action which is attempting to exclude dependencies' contents from the jar. However this also removes LICENSE file from the Jar file since it is quite common for external dependencies to include as well. This is similar to META_INF case which the jar merging tool is special casing and the PR piggy backs on that special case.
|
@jin could you pls take a look? |
jin
approved these changes
Feb 6, 2024
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
maven_project_jar has a jar combining action which is attempting
to exclude dependencies' contents from the jar. However this also
removes LICENSE file from the Jar file since it is quite common for
external dependencies to include as well.
This is similar to META_INF case which the jar merging tool is special
casing and the PR piggy backs on that special case.