tests for artifact with plus #1053
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Related to bazel-contrib#962, reproducing base case that works. Added maven_install stanzas for an artifact that contains plus in its version. Also fixed some test issues related to deleting generated files. File names changed after switching to bzlmod. Added a sanity check in expect_not_in_file() to ensure it's being called for a good file (and not reporting missing string due to missing file). Moved around one test for proper grouping.
gergelyfabian
requested review from
jin,
Wyverald,
shs96c and
cheister
as code owners
shs96c
approved these changes
Feb 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #962, reproducing base case that works. Added maven_install stanzas for an artifact that contains plus in its version.
Also fixed some test issues related to deleting generated files. File names changed after switching to bzlmod.
Added a sanity check in expect_not_in_file() to ensure it's being called for a good file (and not reporting missing string due to missing file).
Moved around one test for proper grouping.