Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

maven_fetch javadoc artifacts are at default visibility #942

Closed
erickj opened this issue Aug 23, 2023 · 1 comment
Closed

maven_fetch javadoc artifacts are at default visibility #942

erickj opened this issue Aug 23, 2023 · 1 comment

Comments

@erickj
Copy link
Contributor

erickj commented Aug 23, 2023

Due to bazelbuild/bazel#13681 the BUILD file generated from maven fetch does not set default visiblity to public. The jvm_import and alias rules manually set visibility = //visibility:public to compensate for this.

The javadoc filegroup does not set this however, making it impossible to access.
erickj added a commit to erickj/rules_jvm_external that referenced this issue Aug 23, 2023
@erickj
Sets javadoc filegroup targets generated from maven_install to include
809d6c8 
visibility = //visiblity:public (bazel-contrib#942)

Verified manually:

filegroup(
        name = "aopalliance_aopalliance_javadoc",
        srcs = ["None"],
        tags = ["javadoc"],
        visibility = ["//visibility:public"],
)
shs96c pushed a commit that referenced this issue Sep 8, 2023
@erickj
Sets javadoc filegroup targets generated from maven_install to include (
53184b5 
#943)

visibility = //visiblity:public (#942)

Verified manually:

filegroup(
        name = "aopalliance_aopalliance_javadoc",
        srcs = ["None"],
        tags = ["javadoc"],
        visibility = ["//visibility:public"],
)
@cheister
Copy link
Collaborator

Fixed with #943

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@erickj @cheister