Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Populate timestamp in test.xml #4259

Merged
merged 2 commits into from
Feb 11, 2025
Merged

Conversation

linzhp
Copy link
Contributor

@linzhp linzhp commented Feb 11, 2025

What type of PR is this?
Feature

What does this PR do? Why is it needed?
The <testsuite> element in JUnit XML has a timestamp attribute, but the <testcase> doesn't, while Go test's json has the timestamp for every event. This PR find the smallest timestamp in the json events and use that as the timestamp of <testsuite>.

Test plan

  • Unit test
  • Verify that the timestamps are different with --runs_per_test=10

@linzhp linzhp requested a review from jayconrod February 11, 2025 05:25
@linzhp linzhp enabled auto-merge (squash) February 11, 2025 17:03
@linzhp linzhp merged commit 4c47d52 into bazel-contrib:master Feb 11, 2025
1 check passed
@linzhp linzhp deleted the timestamp branch February 11, 2025 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants