Allow .so files to have more extensions #4232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some prebuilt libraries have non-digit versions, and we need to allow those. Requirements are relaxed to be in line with bazelbuild/bazel#10148. Fixes bazel-contrib#4227.
fmeum
reviewed
Jan 16, 2025
fmeum
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Bug fix
What does this PR do? Why is it needed?
This PR relaxes requirements on shared libraries' versions to be in line with bazelbuild/bazel#10148. Some prebuilt libraries have non-digit versions, and we need to allow those.
Which issues(s) does this PR fix?
Fixes #4227.
Other notes for review
Bazel uses a regular expression to match version, which is not available in Starlark. I believe this implementation matches it exactly, but if you see some discrepancy — lets see what we can do.
I've also left extra tests that we already had here and added a case that checks library name mentioned in #4227. In result they are not sorted now, but Bazel's implementation does not sort its tests either 🤷