Use rules_shell's sh_binary and sh_test #4182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bazel 8 deletes all native shell rules. In order for other rule repositories (i.e. rules_android) to use rules_go, the references to native sh_* must be converted to rules_shell's respective versions. Unblocks bazelbuild/rules_android#278
fmeum
approved these changes
Nov 26, 2024
|
Thank you, @fmeum! We're hoping to integrate this code ASAP to unblock the next rules_android and Bazel releases. Is there a rules_go release planned soon? |
ted-xie
added a commit
to ted-xie/rules_android
that referenced
this pull request
Nov 27, 2024
Currently relies on git_override and commit archive. Needs a rules_go release containing bazel-contrib/rules_go#4182 to fully productionize.
|
I'm working on an rc2 release that you can upgrade to: #4183 |
ted-xie
added a commit
to ted-xie/rules_android
that referenced
this pull request
Dec 4, 2024
Currently relies on git_override and commit archive. Needs a rules_go release containing bazel-contrib/rules_go#4182 to fully productionize.
ted-xie
added a commit
to ted-xie/rules_android
that referenced
this pull request
Dec 5, 2024
Currently relies on git_override and commit archive. Needs a rules_go release containing bazel-contrib/rules_go#4182 to fully productionize.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bazel 8 deletes all native shell rules. In order for other rule repositories (i.e. rules_android) to use rules_go, the references to native sh_* must be converted to rules_shell's respective versions.
Unblocks bazelbuild/rules_android#278
What type of PR is this?
Bug fix
What does this PR do? Why is it needed?
Adds rules_shell dep and properly loads sh_binary/test where applicable.
Which issues(s) does this PR fix?
Without this PR, rule repositories cannot depend upon rules_go with Bazel 8.
Fixes #4181.
Other notes for review