Support matching release candidate toolchain versions #3998
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JacobOaks
force-pushed
the
joaks/match_rc
branch
from
eb5b369 to
c990b01
Compare
Release candidate versions are of the format `X.YrcZ`. (ex: golang/go@30b6fd6) Unfortunately, this format doesn't get matched properly in `go_toolchain.bzl` so it's not possible to use rc versions without patching `VERSION`, or you'll run into the error, for e.g., with the added test case: ``` no matching toolchains found for types @io_bazel_rules_go//go:toolchain ``` This PR adds a way to match `rc` versions for the toolchain.
JacobOaks
force-pushed
the
joaks/match_rc
branch
from
c990b01 to
518df97
Compare
linzhp
approved these changes
Jul 29, 2024
cgrindel-self-hosted-renovate bot
referenced
this pull request
in cgrindel/bazel-starlib
Aug 30, 2024
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [io_bazel_rules_go](https://redirect.github.com/bazelbuild/rules_go) | http_archive | minor | `v0.49.0` -> `v0.50.0` | --- ### Release Notes <details> <summary>bazelbuild/rules_go (io_bazel_rules_go)</summary> ### [`v0.50.0`](https://redirect.github.com/bazelbuild/rules_go/releases/tag/v0.50.0) [Compare Source](https://redirect.github.com/bazelbuild/rules_go/compare/v0.49.0...v0.50.0) #### `WORKSPACE` code load("@​bazel_tools//tools/build_defs/repo:http.bzl", "http_archive") http_archive( name = "io_bazel_rules_go", sha256 = "67b4d1f517ba73e0a92eb2f57d821f2ddc21f5bc2bd7a231573f11bd8758192e", urls = [ "https://mirror.bazel.build/github.com/bazelbuild/rules_go/releases/download/v0.50.0/rules_go-v0.50.0.zip", "https://github.com/bazelbuild/rules_go/releases/download/v0.50.0/rules_go-v0.50.0.zip", ], ) load("@​io_bazel_rules_go//go:deps.bzl", "go_register_toolchains", "go_rules_dependencies") go_rules_dependencies() go_register_toolchains(version = "1.23.0") #### What's Changed - Break reliance on GOROOT_FINAL by [@​JacobOaks](https://redirect.github.com/JacobOaks) in [https://github.com/bazelbuild/rules_go/pull/3984](https://redirect.github.com/bazelbuild/rules_go/pull/3984) - Migrate to macos_arm64 by [@​meteorcloudy](https://redirect.github.com/meteorcloudy) in [https://github.com/bazelbuild/rules_go/pull/3990](https://redirect.github.com/bazelbuild/rules_go/pull/3990) - Support matching release candidate toolchain versions by [@​JacobOaks](https://redirect.github.com/JacobOaks) in [https://github.com/bazelbuild/rules_go/pull/3998](https://redirect.github.com/bazelbuild/rules_go/pull/3998) - rm crosstool by [@​sluongng](https://redirect.github.com/sluongng) in [https://github.com/bazelbuild/rules_go/pull/3986](https://redirect.github.com/bazelbuild/rules_go/pull/3986) - fix(timeout.go): remove redundant leaked go func in RegisterTimeoutHandler by [@​Roytangrb](https://redirect.github.com/Roytangrb) in [https://github.com/bazelbuild/rules_go/pull/4004](https://redirect.github.com/bazelbuild/rules_go/pull/4004) - Run nogo in a separate validation action by [@​fmeum](https://redirect.github.com/fmeum) in [https://github.com/bazelbuild/rules_go/pull/3995](https://redirect.github.com/bazelbuild/rules_go/pull/3995) #### New Contributors - [@​JacobOaks](https://redirect.github.com/JacobOaks) made their first contribution in [https://github.com/bazelbuild/rules_go/pull/3984](https://redirect.github.com/bazelbuild/rules_go/pull/3984) - [@​Roytangrb](https://redirect.github.com/Roytangrb) made their first contribution in [https://github.com/bazelbuild/rules_go/pull/4004](https://redirect.github.com/bazelbuild/rules_go/pull/4004) **Full Changelog**: bazel-contrib/rules_go@release-0.49...release-0.50 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://redirect.github.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://redirect.github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC41OC4wIiwidXBkYXRlZEluVmVyIjoiMzguNTguMCIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOltdfQ==--> Co-authored-by: cgrindel-self-hosted-renovate[bot] <139595543+cgrindel-self-hosted-renovate[bot]@users.noreply.github.com>
renovate bot
referenced
this pull request
in kreempuff/rules_unreal_engine
Aug 30, 2024
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [io_bazel_rules_go](https://togithub.com/bazelbuild/rules_go) | http_archive | minor | `v0.49.0` -> `v0.50.0` | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>bazelbuild/rules_go (io_bazel_rules_go)</summary> ### [`v0.50.0`](https://togithub.com/bazelbuild/rules_go/releases/tag/v0.50.0) [Compare Source](https://togithub.com/bazelbuild/rules_go/compare/v0.49.0...v0.50.0) #### `WORKSPACE` code load("@​bazel_tools//tools/build_defs/repo:http.bzl", "http_archive") http_archive( name = "io_bazel_rules_go", sha256 = "67b4d1f517ba73e0a92eb2f57d821f2ddc21f5bc2bd7a231573f11bd8758192e", urls = [ "https://mirror.bazel.build/github.com/bazelbuild/rules_go/releases/download/v0.50.0/rules_go-v0.50.0.zip", "https://github.com/bazelbuild/rules_go/releases/download/v0.50.0/rules_go-v0.50.0.zip", ], ) load("@​io_bazel_rules_go//go:deps.bzl", "go_register_toolchains", "go_rules_dependencies") go_rules_dependencies() go_register_toolchains(version = "1.23.0") #### What's Changed - Break reliance on GOROOT_FINAL by [@​JacobOaks](https://togithub.com/JacobOaks) in [https://github.com/bazelbuild/rules_go/pull/3984](https://togithub.com/bazelbuild/rules_go/pull/3984) - Migrate to macos_arm64 by [@​meteorcloudy](https://togithub.com/meteorcloudy) in [https://github.com/bazelbuild/rules_go/pull/3990](https://togithub.com/bazelbuild/rules_go/pull/3990) - Support matching release candidate toolchain versions by [@​JacobOaks](https://togithub.com/JacobOaks) in [https://github.com/bazelbuild/rules_go/pull/3998](https://togithub.com/bazelbuild/rules_go/pull/3998) - rm crosstool by [@​sluongng](https://togithub.com/sluongng) in [https://github.com/bazelbuild/rules_go/pull/3986](https://togithub.com/bazelbuild/rules_go/pull/3986) - fix(timeout.go): remove redundant leaked go func in RegisterTimeoutHandler by [@​Roytangrb](https://togithub.com/Roytangrb) in [https://github.com/bazelbuild/rules_go/pull/4004](https://togithub.com/bazelbuild/rules_go/pull/4004) - Run nogo in a separate validation action by [@​fmeum](https://togithub.com/fmeum) in [https://github.com/bazelbuild/rules_go/pull/3995](https://togithub.com/bazelbuild/rules_go/pull/3995) #### New Contributors - [@​JacobOaks](https://togithub.com/JacobOaks) made their first contribution in [https://github.com/bazelbuild/rules_go/pull/3984](https://togithub.com/bazelbuild/rules_go/pull/3984) - [@​Roytangrb](https://togithub.com/Roytangrb) made their first contribution in [https://github.com/bazelbuild/rules_go/pull/4004](https://togithub.com/bazelbuild/rules_go/pull/4004) **Full Changelog**: bazel-contrib/rules_go@release-0.49...release-0.50 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://mend.io/renovate/). View the [repository job log](https://developer.mend.io/github/kreempuff/rules_unreal_engine). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC41Ni4wIiwidXBkYXRlZEluVmVyIjoiMzguNTYuMCIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOltdfQ==-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Bug fix
What does this PR do? Why is it needed?
Go release candidate versions are of the format
X.YrcZ. (ex: golang/go@30b6fd6)Unfortunately, this format doesn't get matched properly in
go_toolchain.bzlso it's not possible to use rc versions without patchingVERSION, or you'll run into the error, for e.g., with the added test case:This PR adds a way to match
rcversions for the toolchain.