Add Bzlmod support for `nogo` #3782

fmeum · 2023-12-11T20:07:30Z

What type of PR is this?

Feature

What does this PR do? Why is it needed?

See bzlmod.md for the details. This change is backwards compatible for WORKSPACE setups, but allows finer control over the set of targets nogo is applied to when using Bzlmod.

Which issues(s) does this PR fix?

Fixes #3529

Other notes for review

fmeum · 2023-12-11T20:08:16Z

@sluongng I would be interested in your opinion on this.

sluongng

This PR does a few things:

Introduce calling of go_register_nogo inside a new tag of go_sdk. This help user start registering their nogo binary 👍
A _get_nogo mechanism to exclude and include which Bazel packages can be subjected to nogo analysis. This could be easier reviewed if it’s introduced in a separate PR, but now that you have included it here, no need to spend more time on splitting it.

Overall I think (2) provides a better, more sensible default than what we have today. Though it’s a bit overlap with the nogo_config.json mechanism we current have in rules nogo(). I think we should add a deprecation notice to the include/exclude in nogo_config.json so we could phase it out in favor of this one.

Finally the bcr test demonstrated how nogo could be setup in a repo and how some certain packages could be excluded. I think we are missing a “test for nogo failure” case here, but I am not quite sure if the current test setup would allow that. Is it possible to setup a test like that under //tests/core/nogo?

Overall this LGTM. Thanks a lot for working on it 🙏

fmeum · 2023-12-11T20:59:51Z

I think we are missing a “test for nogo failure” case here, but I am not quite sure if the current test setup would allow that. Is it possible to setup a test like that under //tests/core/nogo?

It doesn't right now, but I will add a regular go_bazel_test covering the inclusion/exclusion logic as well as some Starlark tests.

fmeum · 2023-12-12T11:10:20Z

Making go_bazel_test usable for Bzlmod tests will take some effort, depending on the level of test runtime efficiency we aim for. I will see whether I can produce something that works quickly.

I added Starlark tests and more docs.

tyler-french

Tested at Uber. LGTM!

sluongng

Few style nits/questions, but LGTM overall

MODULE.bazel

go/private/context.bzl

go/private/extensions.bzl

go/tools/bazel_testing/bazel_testing.go

tyler-french

Looks great! All of my comments are just Go style nits.
I tested the latest and it works great!

go/tools/bazel_testing/bazel_testing.go

tests/core/nogo/bzlmod/includes_excludes_test.go

go/tools/bazel_testing/bazel_testing.go

See `bzlmod.md` for the details. This change is backwards compatible for WORKSPACE setups, but allows finer control over the set of targets nogo is applied to when using Bzlmod.

Requires some changes to the `go_bazel_test` setup.

This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [io_bazel_rules_go](https://togithub.com/bazelbuild/rules_go) | http_archive | minor | `v0.43.0` -> `v0.44.0` | --- ### Release Notes <details> <summary>bazelbuild/rules_go (io_bazel_rules_go)</summary> ### [`v0.44.0`](https://togithub.com/bazelbuild/rules_go/releases/tag/v0.44.0) [Compare Source](https://togithub.com/bazelbuild/rules_go/compare/v0.43.0...v0.44.0) ### IMPORTANT CHANGES #### Tests now call `panic()` when they timeout This means there is a running goroutine (which will fail [goleak](https://togithub.com/uber-go/goleak) detection) [Goroutine 26 in state chan receive, with github.com/bazelbuild/rules_go/go/tools/bzltestutil.RegisterTimeoutHandler.func1 on top of the This also means there may be some different behavior when calling `SIGTERM` directly from within a test. For more information see: [https://github.com/bazelbuild/rules_go/pull/3749](https://togithub.com/bazelbuild/rules_go/pull/3749) #### Bzlmod support for `nogo` This can be added in your `MODULE.bazel` file: go_sdk = use_extension("@io_bazel_rules_go//go:extensions.bzl", "go_sdk") go_sdk.download( name = "go_sdk", ... ) go_sdk.nogo( nogo = "//:default_nogo", ) For more information see [https://github.com/bazelbuild/rules_go/pull/3782](https://togithub.com/bazelbuild/rules_go/pull/3782) #### `WORKSPACE` code load("@bazel_tools//tools/build_defs/repo:http.bzl", "http_archive") http_archive( name = "io_bazel_rules_go", sha256 = "c8035e8ae248b56040a65ad3f0b7434712e2037e5dfdcebfe97576e620422709", urls = [ "https://mirror.bazel.build/github.com/bazelbuild/rules_go/releases/download/v0.44.0/rules_go-v0.44.0.zip", "https://github.com/bazelbuild/rules_go/releases/download/v0.44.0/rules_go-v0.44.0.zip", ], ) load("@io_bazel_rules_go//go:deps.bzl", "go_register_toolchains", "go_rules_dependencies") go_rules_dependencies() go_register_toolchains(version = "1.21.5") #### What's Changed - Do not test on centos7 by [@fmeum](https://togithub.com/fmeum) in [https://github.com/bazelbuild/rules_go/pull/3757](https://togithub.com/bazelbuild/rules_go/pull/3757) - update documentation for 0.43.0 release by [@tyler-french](https://togithub.com/tyler-french) in [https://github.com/bazelbuild/rules_go/pull/3758](https://togithub.com/bazelbuild/rules_go/pull/3758) - Add toolchain param to affected actions by [@kotlaja](https://togithub.com/kotlaja) in [https://github.com/bazelbuild/rules_go/pull/3760](https://togithub.com/bazelbuild/rules_go/pull/3760) - Update GO_TOOLCHAIN string to Label and add toolchain param to one more action by [@kotlaja](https://togithub.com/kotlaja) in [https://github.com/bazelbuild/rules_go/pull/3762](https://togithub.com/bazelbuild/rules_go/pull/3762) - Do not choose prereleases as highest versions by [@mering](https://togithub.com/mering) in [https://github.com/bazelbuild/rules_go/pull/3764](https://togithub.com/bazelbuild/rules_go/pull/3764) - Remove unmaintained validators by [@mering](https://togithub.com/mering) in [https://github.com/bazelbuild/rules_go/pull/3768](https://togithub.com/bazelbuild/rules_go/pull/3768) - Use `tools.go` trick to make `go.mod` work with `go mod tidy` by [@fmeum](https://togithub.com/fmeum) in [https://github.com/bazelbuild/rules_go/pull/3775](https://togithub.com/bazelbuild/rules_go/pull/3775) - feat(packagesdriver): add \_test suffix to pkgPath by [@JamyDev](https://togithub.com/JamyDev) in [https://github.com/bazelbuild/rules_go/pull/3777](https://togithub.com/bazelbuild/rules_go/pull/3777) - Typo --test_runner_fail_fast by [@Clement-Jean](https://togithub.com/Clement-Jean) in [https://github.com/bazelbuild/rules_go/pull/3773](https://togithub.com/bazelbuild/rules_go/pull/3773) - Panic when a test times out by [@fmeum](https://togithub.com/fmeum) in [https://github.com/bazelbuild/rules_go/pull/3749](https://togithub.com/bazelbuild/rules_go/pull/3749) - Fix integration tests with Bazel@HEAD by [@fmeum](https://togithub.com/fmeum) in [https://github.com/bazelbuild/rules_go/pull/3781](https://togithub.com/bazelbuild/rules_go/pull/3781) - Automatically register SDKs for common execution platforms by [@fmeum](https://togithub.com/fmeum) in [https://github.com/bazelbuild/rules_go/pull/3634](https://togithub.com/bazelbuild/rules_go/pull/3634) - fix `aux_files` relative paths for gomock source mocks (fix [#3752](https://togithub.com/bazelbuild/rules_go/issues/3752)) by [@ikavalio](https://togithub.com/ikavalio) in [https://github.com/bazelbuild/rules_go/pull/3753](https://togithub.com/bazelbuild/rules_go/pull/3753) - Update to modern protoc plugins by [@mering](https://togithub.com/mering) in [https://github.com/bazelbuild/rules_go/pull/3761](https://togithub.com/bazelbuild/rules_go/pull/3761) - Add integration tests for protoc-gen-go-grpc by [@ryanpbrewster](https://togithub.com/ryanpbrewster) in [https://github.com/bazelbuild/rules_go/pull/3787](https://togithub.com/bazelbuild/rules_go/pull/3787) - Add Bzlmod support for `nogo` by [@fmeum](https://togithub.com/fmeum) in [https://github.com/bazelbuild/rules_go/pull/3782](https://togithub.com/bazelbuild/rules_go/pull/3782) - fix(gpd): don't panic on invalid root by [@JamyDev](https://togithub.com/JamyDev) in [https://github.com/bazelbuild/rules_go/pull/3779](https://togithub.com/bazelbuild/rules_go/pull/3779) - Pass env to gentestmain so it will correctly filter by [@patrickmscott](https://togithub.com/patrickmscott) in [https://github.com/bazelbuild/rules_go/pull/3785](https://togithub.com/bazelbuild/rules_go/pull/3785) - prepare release 0.44.0 by [@tyler-french](https://togithub.com/tyler-french) in [https://github.com/bazelbuild/rules_go/pull/3788](https://togithub.com/bazelbuild/rules_go/pull/3788) #### New Contributors - [@Clement-Jean](https://togithub.com/Clement-Jean) made their first contribution in [https://github.com/bazelbuild/rules_go/pull/3773](https://togithub.com/bazelbuild/rules_go/pull/3773) - [@ikavalio](https://togithub.com/ikavalio) made their first contribution in [https://github.com/bazelbuild/rules_go/pull/3753](https://togithub.com/bazelbuild/rules_go/pull/3753) - [@ryanpbrewster](https://togithub.com/ryanpbrewster) made their first contribution in [https://github.com/bazelbuild/rules_go/pull/3787](https://togithub.com/bazelbuild/rules_go/pull/3787) **Full Changelog**: bazel-contrib/rules_go@v0.43.0...v0.44.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://togithub.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate).  Co-authored-by: Self-hosted Renovate Bot <361546+cgrindel-self-hosted-renovate[bot]@users.noreply.github.enterprise.com>

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [io_bazel_rules_go](https://togithub.com/bazelbuild/rules_go) | http_archive | minor | `v0.43.0` -> `v0.44.0` | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>bazelbuild/rules_go (io_bazel_rules_go)</summary> ### [`v0.44.0`](https://togithub.com/bazelbuild/rules_go/releases/tag/v0.44.0) [Compare Source](https://togithub.com/bazelbuild/rules_go/compare/v0.43.0...v0.44.0) ### IMPORTANT CHANGES #### Tests now call `panic()` when they timeout This means there is a running goroutine (which will fail [goleak](https://togithub.com/uber-go/goleak) detection) [Goroutine 26 in state chan receive, with github.com/bazelbuild/rules_go/go/tools/bzltestutil.RegisterTimeoutHandler.func1 on top of the This also means there may be some different behavior when calling `SIGTERM` directly from within a test. For more information see: [https://github.com/bazelbuild/rules_go/pull/3749](https://togithub.com/bazelbuild/rules_go/pull/3749) #### Bzlmod support for `nogo` This can be added in your `MODULE.bazel` file: go_sdk = use_extension("@io_bazel_rules_go//go:extensions.bzl", "go_sdk") go_sdk.download( name = "go_sdk", ... ) go_sdk.nogo( nogo = "//:default_nogo", ) For more information see [https://github.com/bazelbuild/rules_go/pull/3782](https://togithub.com/bazelbuild/rules_go/pull/3782) #### `WORKSPACE` code load("@bazel_tools//tools/build_defs/repo:http.bzl", "http_archive") http_archive( name = "io_bazel_rules_go", sha256 = "c8035e8ae248b56040a65ad3f0b7434712e2037e5dfdcebfe97576e620422709", urls = [ "https://mirror.bazel.build/github.com/bazelbuild/rules_go/releases/download/v0.44.0/rules_go-v0.44.0.zip", "https://github.com/bazelbuild/rules_go/releases/download/v0.44.0/rules_go-v0.44.0.zip", ], ) load("@io_bazel_rules_go//go:deps.bzl", "go_register_toolchains", "go_rules_dependencies") go_rules_dependencies() go_register_toolchains(version = "1.21.5") #### What's Changed - Do not test on centos7 by [@fmeum](https://togithub.com/fmeum) in [https://github.com/bazelbuild/rules_go/pull/3757](https://togithub.com/bazelbuild/rules_go/pull/3757) - update documentation for 0.43.0 release by [@tyler-french](https://togithub.com/tyler-french) in [https://github.com/bazelbuild/rules_go/pull/3758](https://togithub.com/bazelbuild/rules_go/pull/3758) - Add toolchain param to affected actions by [@kotlaja](https://togithub.com/kotlaja) in [https://github.com/bazelbuild/rules_go/pull/3760](https://togithub.com/bazelbuild/rules_go/pull/3760) - Update GO_TOOLCHAIN string to Label and add toolchain param to one more action by [@kotlaja](https://togithub.com/kotlaja) in [https://github.com/bazelbuild/rules_go/pull/3762](https://togithub.com/bazelbuild/rules_go/pull/3762) - Do not choose prereleases as highest versions by [@mering](https://togithub.com/mering) in [https://github.com/bazelbuild/rules_go/pull/3764](https://togithub.com/bazelbuild/rules_go/pull/3764) - Remove unmaintained validators by [@mering](https://togithub.com/mering) in [https://github.com/bazelbuild/rules_go/pull/3768](https://togithub.com/bazelbuild/rules_go/pull/3768) - Use `tools.go` trick to make `go.mod` work with `go mod tidy` by [@fmeum](https://togithub.com/fmeum) in [https://github.com/bazelbuild/rules_go/pull/3775](https://togithub.com/bazelbuild/rules_go/pull/3775) - feat(packagesdriver): add \_test suffix to pkgPath by [@JamyDev](https://togithub.com/JamyDev) in [https://github.com/bazelbuild/rules_go/pull/3777](https://togithub.com/bazelbuild/rules_go/pull/3777) - Typo --test_runner_fail_fast by [@Clement-Jean](https://togithub.com/Clement-Jean) in [https://github.com/bazelbuild/rules_go/pull/3773](https://togithub.com/bazelbuild/rules_go/pull/3773) - Panic when a test times out by [@fmeum](https://togithub.com/fmeum) in [https://github.com/bazelbuild/rules_go/pull/3749](https://togithub.com/bazelbuild/rules_go/pull/3749) - Fix integration tests with Bazel@HEAD by [@fmeum](https://togithub.com/fmeum) in [https://github.com/bazelbuild/rules_go/pull/3781](https://togithub.com/bazelbuild/rules_go/pull/3781) - Automatically register SDKs for common execution platforms by [@fmeum](https://togithub.com/fmeum) in [https://github.com/bazelbuild/rules_go/pull/3634](https://togithub.com/bazelbuild/rules_go/pull/3634) - fix `aux_files` relative paths for gomock source mocks (fix [#3752](https://togithub.com/bazelbuild/rules_go/issues/3752)) by [@ikavalio](https://togithub.com/ikavalio) in [https://github.com/bazelbuild/rules_go/pull/3753](https://togithub.com/bazelbuild/rules_go/pull/3753) - Update to modern protoc plugins by [@mering](https://togithub.com/mering) in [https://github.com/bazelbuild/rules_go/pull/3761](https://togithub.com/bazelbuild/rules_go/pull/3761) - Add integration tests for protoc-gen-go-grpc by [@ryanpbrewster](https://togithub.com/ryanpbrewster) in [https://github.com/bazelbuild/rules_go/pull/3787](https://togithub.com/bazelbuild/rules_go/pull/3787) - Add Bzlmod support for `nogo` by [@fmeum](https://togithub.com/fmeum) in [https://github.com/bazelbuild/rules_go/pull/3782](https://togithub.com/bazelbuild/rules_go/pull/3782) - fix(gpd): don't panic on invalid root by [@JamyDev](https://togithub.com/JamyDev) in [https://github.com/bazelbuild/rules_go/pull/3779](https://togithub.com/bazelbuild/rules_go/pull/3779) - Pass env to gentestmain so it will correctly filter by [@patrickmscott](https://togithub.com/patrickmscott) in [https://github.com/bazelbuild/rules_go/pull/3785](https://togithub.com/bazelbuild/rules_go/pull/3785) - prepare release 0.44.0 by [@tyler-french](https://togithub.com/tyler-french) in [https://github.com/bazelbuild/rules_go/pull/3788](https://togithub.com/bazelbuild/rules_go/pull/3788) #### New Contributors - [@Clement-Jean](https://togithub.com/Clement-Jean) made their first contribution in [https://github.com/bazelbuild/rules_go/pull/3773](https://togithub.com/bazelbuild/rules_go/pull/3773) - [@ikavalio](https://togithub.com/ikavalio) made their first contribution in [https://github.com/bazelbuild/rules_go/pull/3753](https://togithub.com/bazelbuild/rules_go/pull/3753) - [@ryanpbrewster](https://togithub.com/ryanpbrewster) made their first contribution in [https://github.com/bazelbuild/rules_go/pull/3787](https://togithub.com/bazelbuild/rules_go/pull/3787) **Full Changelog**: bazel-contrib/rules_go@v0.43.0...v0.44.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/kreempuff/rules_unreal_engine).

This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [io_bazel_rules_go](https://togithub.com/bazelbuild/rules_go) | http_archive | minor | `v0.43.0` -> `v0.44.0` | --- ### Release Notes <details> <summary>bazelbuild/rules_go (io_bazel_rules_go)</summary> ### [`v0.44.0`](https://togithub.com/bazelbuild/rules_go/releases/tag/v0.44.0) [Compare Source](https://togithub.com/bazelbuild/rules_go/compare/v0.43.0...v0.44.0) ### IMPORTANT CHANGES #### Tests now call `panic()` when they timeout This means there is a running goroutine (which will fail [goleak](https://togithub.com/uber-go/goleak) detection) [Goroutine 26 in state chan receive, with github.com/bazelbuild/rules_go/go/tools/bzltestutil.RegisterTimeoutHandler.func1 on top of the This also means there may be some different behavior when calling `SIGTERM` directly from within a test. For more information see: [https://github.com/bazelbuild/rules_go/pull/3749](https://togithub.com/bazelbuild/rules_go/pull/3749) #### Bzlmod support for `nogo` This can be added in your `MODULE.bazel` file: go_sdk = use_extension("@io_bazel_rules_go//go:extensions.bzl", "go_sdk") go_sdk.download( name = "go_sdk", ... ) go_sdk.nogo( nogo = "//:default_nogo", ) For more information see [https://github.com/bazelbuild/rules_go/pull/3782](https://togithub.com/bazelbuild/rules_go/pull/3782) #### `WORKSPACE` code load("@bazel_tools//tools/build_defs/repo:http.bzl", "http_archive") http_archive( name = "io_bazel_rules_go", sha256 = "c8035e8ae248b56040a65ad3f0b7434712e2037e5dfdcebfe97576e620422709", urls = [ "https://mirror.bazel.build/github.com/bazelbuild/rules_go/releases/download/v0.44.0/rules_go-v0.44.0.zip", "https://github.com/bazelbuild/rules_go/releases/download/v0.44.0/rules_go-v0.44.0.zip", ], ) load("@io_bazel_rules_go//go:deps.bzl", "go_register_toolchains", "go_rules_dependencies") go_rules_dependencies() go_register_toolchains(version = "1.21.5") #### What's Changed - Do not test on centos7 by [@fmeum](https://togithub.com/fmeum) in [https://github.com/bazelbuild/rules_go/pull/3757](https://togithub.com/bazelbuild/rules_go/pull/3757) - update documentation for 0.43.0 release by [@tyler-french](https://togithub.com/tyler-french) in [https://github.com/bazelbuild/rules_go/pull/3758](https://togithub.com/bazelbuild/rules_go/pull/3758) - Add toolchain param to affected actions by [@kotlaja](https://togithub.com/kotlaja) in [https://github.com/bazelbuild/rules_go/pull/3760](https://togithub.com/bazelbuild/rules_go/pull/3760) - Update GO_TOOLCHAIN string to Label and add toolchain param to one more action by [@kotlaja](https://togithub.com/kotlaja) in [https://github.com/bazelbuild/rules_go/pull/3762](https://togithub.com/bazelbuild/rules_go/pull/3762) - Do not choose prereleases as highest versions by [@mering](https://togithub.com/mering) in [https://github.com/bazelbuild/rules_go/pull/3764](https://togithub.com/bazelbuild/rules_go/pull/3764) - Remove unmaintained validators by [@mering](https://togithub.com/mering) in [https://github.com/bazelbuild/rules_go/pull/3768](https://togithub.com/bazelbuild/rules_go/pull/3768) - Use `tools.go` trick to make `go.mod` work with `go mod tidy` by [@fmeum](https://togithub.com/fmeum) in [https://github.com/bazelbuild/rules_go/pull/3775](https://togithub.com/bazelbuild/rules_go/pull/3775) - feat(packagesdriver): add \_test suffix to pkgPath by [@JamyDev](https://togithub.com/JamyDev) in [https://github.com/bazelbuild/rules_go/pull/3777](https://togithub.com/bazelbuild/rules_go/pull/3777) - Typo --test_runner_fail_fast by [@Clement-Jean](https://togithub.com/Clement-Jean) in [https://github.com/bazelbuild/rules_go/pull/3773](https://togithub.com/bazelbuild/rules_go/pull/3773) - Panic when a test times out by [@fmeum](https://togithub.com/fmeum) in [https://github.com/bazelbuild/rules_go/pull/3749](https://togithub.com/bazelbuild/rules_go/pull/3749) - Fix integration tests with Bazel@HEAD by [@fmeum](https://togithub.com/fmeum) in [https://github.com/bazelbuild/rules_go/pull/3781](https://togithub.com/bazelbuild/rules_go/pull/3781) - Automatically register SDKs for common execution platforms by [@fmeum](https://togithub.com/fmeum) in [https://github.com/bazelbuild/rules_go/pull/3634](https://togithub.com/bazelbuild/rules_go/pull/3634) - fix `aux_files` relative paths for gomock source mocks (fix [#3752](https://togithub.com/bazelbuild/rules_go/issues/3752)) by [@ikavalio](https://togithub.com/ikavalio) in [https://github.com/bazelbuild/rules_go/pull/3753](https://togithub.com/bazelbuild/rules_go/pull/3753) - Update to modern protoc plugins by [@mering](https://togithub.com/mering) in [https://github.com/bazelbuild/rules_go/pull/3761](https://togithub.com/bazelbuild/rules_go/pull/3761) - Add integration tests for protoc-gen-go-grpc by [@ryanpbrewster](https://togithub.com/ryanpbrewster) in [https://github.com/bazelbuild/rules_go/pull/3787](https://togithub.com/bazelbuild/rules_go/pull/3787) - Add Bzlmod support for `nogo` by [@fmeum](https://togithub.com/fmeum) in [https://github.com/bazelbuild/rules_go/pull/3782](https://togithub.com/bazelbuild/rules_go/pull/3782) - fix(gpd): don't panic on invalid root by [@JamyDev](https://togithub.com/JamyDev) in [https://github.com/bazelbuild/rules_go/pull/3779](https://togithub.com/bazelbuild/rules_go/pull/3779) - Pass env to gentestmain so it will correctly filter by [@patrickmscott](https://togithub.com/patrickmscott) in [https://github.com/bazelbuild/rules_go/pull/3785](https://togithub.com/bazelbuild/rules_go/pull/3785) - prepare release 0.44.0 by [@tyler-french](https://togithub.com/tyler-french) in [https://github.com/bazelbuild/rules_go/pull/3788](https://togithub.com/bazelbuild/rules_go/pull/3788) #### New Contributors - [@Clement-Jean](https://togithub.com/Clement-Jean) made their first contribution in [https://github.com/bazelbuild/rules_go/pull/3773](https://togithub.com/bazelbuild/rules_go/pull/3773) - [@ikavalio](https://togithub.com/ikavalio) made their first contribution in [https://github.com/bazelbuild/rules_go/pull/3753](https://togithub.com/bazelbuild/rules_go/pull/3753) - [@ryanpbrewster](https://togithub.com/ryanpbrewster) made their first contribution in [https://github.com/bazelbuild/rules_go/pull/3787](https://togithub.com/bazelbuild/rules_go/pull/3787) **Full Changelog**: bazel-contrib/rules_go@v0.43.0...v0.44.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://togithub.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate).  Co-authored-by: Self-hosted Renovate Bot <361546+cgrindel-self-hosted-renovate[bot]@users.noreply.github.enterprise.com>

fmeum requested a review from tyler-french December 11, 2023 20:07

fmeum force-pushed the nogo-bzlmod branch 4 times, most recently from 27a2717 to 42a0fdd Compare December 11, 2023 20:38

sluongng reviewed Dec 11, 2023

View reviewed changes

fmeum force-pushed the nogo-bzlmod branch from 42a0fdd to 018d85b Compare December 11, 2023 20:51

fmeum force-pushed the nogo-bzlmod branch 3 times, most recently from 2d39674 to 86baec4 Compare December 12, 2023 11:09

fmeum force-pushed the nogo-bzlmod branch from 86baec4 to 7459413 Compare December 12, 2023 11:19

tyler-french approved these changes Dec 12, 2023

View reviewed changes

fmeum force-pushed the nogo-bzlmod branch 2 times, most recently from 87d36c7 to e5b9b8a Compare December 13, 2023 10:20

fmeum requested review from tyler-french and sluongng December 13, 2023 10:43

sluongng approved these changes Dec 13, 2023

View reviewed changes

MODULE.bazel Show resolved Hide resolved

go/private/context.bzl Outdated Show resolved Hide resolved

go/private/extensions.bzl Show resolved Hide resolved

go/tools/bazel_testing/bazel_testing.go Show resolved Hide resolved

fmeum force-pushed the nogo-bzlmod branch from e5b9b8a to 94de14f Compare December 13, 2023 12:17

tyler-french approved these changes Dec 14, 2023

View reviewed changes

motiejus mentioned this pull request Dec 14, 2023

[internal chore] nogo support uber/hermetic_cc_toolchain#136

Open

motiejus reviewed Dec 14, 2023

View reviewed changes

go/tools/bazel_testing/bazel_testing.go Show resolved Hide resolved

fmeum added 5 commits December 14, 2023 17:47

Add Bzlmod support for nogo

0f4305f

See `bzlmod.md` for the details. This change is backwards compatible for WORKSPACE setups, but allows finer control over the set of targets nogo is applied to when using Bzlmod.

Add test for matches_scope

0bd5b31

Mention in nogo.rst

7dfe566

Add go_bazel_test for nogo

6f16079

Requires some changes to the `go_bazel_test` setup.

Address review comments

1e5b9e2

fmeum force-pushed the nogo-bzlmod branch from 94de14f to 1e5b9e2 Compare December 14, 2023 16:47

fmeum merged commit d5bc6ad into master Dec 14, 2023
5 checks passed

fmeum deleted the nogo-bzlmod branch December 14, 2023 17:27

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Bzlmod support for `nogo` #3782

Add Bzlmod support for `nogo` #3782

fmeum commented Dec 11, 2023

fmeum commented Dec 11, 2023

sluongng left a comment

fmeum commented Dec 11, 2023

fmeum commented Dec 12, 2023 •

edited

Loading

tyler-french left a comment

sluongng left a comment

tyler-french left a comment

Add Bzlmod support for nogo #3782

Add Bzlmod support for nogo #3782

Conversation

fmeum commented Dec 11, 2023

fmeum commented Dec 11, 2023

sluongng left a comment

Choose a reason for hiding this comment

fmeum commented Dec 11, 2023

fmeum commented Dec 12, 2023 • edited Loading

tyler-french left a comment

Choose a reason for hiding this comment

sluongng left a comment

Choose a reason for hiding this comment

tyler-french left a comment

Choose a reason for hiding this comment

Add Bzlmod support for `nogo` #3782

Add Bzlmod support for `nogo` #3782

fmeum commented Dec 12, 2023 •

edited

Loading