Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(gopackagesdriver): add base test case for go packages driver #3743

Merged
merged 12 commits into from
Nov 9, 2023

Conversation

JamyDev
Copy link
Contributor

@JamyDev JamyDev commented Nov 1, 2023

What type of PR is this?

Other - Test cases

What does this PR do? Why is it needed?

Validates the basic functionality for the Go Packages Driver, and sets up a framework to add additional tests in the future.

Two major changes were needed to support all testing platforms:

  • For bazel <6.0 we need to use the old style labels. Currently it would always prefix with @ and fail the lookup on bazel 5.
  • For Windows we need to adjust the paths returned from Bazel. I think because we're running inside MINGW the paths are unix like where everything starts with \, but since Bazel runs in Java it uses regular Windows paths (eg C:\<some>\<path>). So if we see a path like \C:\<some>\<path> we have to remove the leading \ for go to be able tom resolve this path.

This should help contributors validate that changes they make to this functionality and hopefully means less regressions overall.

Other notes for review

The goal is to test more scenarios, but wanted to send in the initial approach for review.

@JamyDev JamyDev changed the title feat(tests): add base test case for go packages driver feat(gopackagesdriver): add base test case for go packages driver Nov 1, 2023
@fmeum
Copy link
Member

fmeum commented Nov 3, 2023

Thank you very much, this was sorely lacking!

Just mention me when you think this is ready. CI is unfortunately still failing.

@JamyDev
Copy link
Contributor Author

JamyDev commented Nov 3, 2023

Thanks yeah, it was passing locally so I'll investigate today!

@JamyDev
Copy link
Contributor Author

JamyDev commented Nov 5, 2023

Ready to be reviewed @fmeum

Copy link
Member

@fmeum fmeum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thank you very much!
The bug fixes may even end up resolving some open issues.

go/tools/bazel_testing/bazel_testing.go Show resolved Hide resolved
@fmeum fmeum force-pushed the feat/gopackagesdriver-tests branch from 75f3df7 to f1fe653 Compare November 9, 2023 16:17
@fmeum fmeum enabled auto-merge (squash) November 9, 2023 16:17
@fmeum fmeum merged commit d8bf98b into bazel-contrib:master Nov 9, 2023
1 check passed
@JamyDev JamyDev deleted the feat/gopackagesdriver-tests branch November 9, 2023 18:03
renovate bot referenced this pull request in kreempuff/rules_unreal_engine Nov 20, 2023
[![Mend Renovate logo
banner](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [io_bazel_rules_go](https://togithub.com/bazelbuild/rules_go) |
http_archive | minor | `v0.42.0` -> `v0.43.0` |

---

> [!WARNING]
> Some dependencies could not be looked up. Check the Dependency
Dashboard for more information.

---

### Release Notes

<details>
<summary>bazelbuild/rules_go (io_bazel_rules_go)</summary>

###
[`v0.43.0`](https://togithub.com/bazelbuild/rules_go/releases/tag/v0.43.0)

[Compare
Source](https://togithub.com/bazelbuild/rules_go/compare/v0.42.0...v0.43.0)

#### Breaking `x/tools` upgrade

This change includes a breaking upgrade to
[golang.org/x/tools](https://pkg.go.dev/golang.org/x/tools)

Please make sure to upgrade `x/tools` to version `v0.15.0` to ensure
compatibility with rules_go's NoGo.

**If you need to use an older version of `x/tools` (`v0.13.0` or
earlier), apply the following patch to `rules_go`**:

[x-tools.patch](https://togithub.com/bazelbuild/rules_go/files/13417624/x-tools.patch)

#### What's Changed

- Test BCR test module on macos_arm64 by
[@&#8203;fmeum](https://togithub.com/fmeum) in
[https://github.com/bazelbuild/rules_go/pull/3715](https://togithub.com/bazelbuild/rules_go/pull/3715)
- update documentation for `0.42.0` release by
[@&#8203;tyler-french](https://togithub.com/tyler-french) in
[https://github.com/bazelbuild/rules_go/pull/3716](https://togithub.com/bazelbuild/rules_go/pull/3716)
- add netrc support to go_download_sdk by
[@&#8203;justinwon777](https://togithub.com/justinwon777) in
[https://github.com/bazelbuild/rules_go/pull/3718](https://togithub.com/bazelbuild/rules_go/pull/3718)
- Temporarily disable Bzlmod explicitly by
[@&#8203;fmeum](https://togithub.com/fmeum) in
[https://github.com/bazelbuild/rules_go/pull/3720](https://togithub.com/bazelbuild/rules_go/pull/3720)
- Fix urls used to get auth in go_download_sdk by
[@&#8203;justinwon777](https://togithub.com/justinwon777) in
[https://github.com/bazelbuild/rules_go/pull/3724](https://togithub.com/bazelbuild/rules_go/pull/3724)
- Include `go.env` in `//go` runfiles by
[@&#8203;fmeum](https://togithub.com/fmeum) in
[https://github.com/bazelbuild/rules_go/pull/3722](https://togithub.com/bazelbuild/rules_go/pull/3722)
- Update arm platform constraint to latest value in bazel. by
[@&#8203;BryanDClark](https://togithub.com/BryanDClark) in
[https://github.com/bazelbuild/rules_go/pull/3734](https://togithub.com/bazelbuild/rules_go/pull/3734)
- Add toolchain param to affected actions by
[@&#8203;kotlaja](https://togithub.com/kotlaja) in
[https://github.com/bazelbuild/rules_go/pull/3740](https://togithub.com/bazelbuild/rules_go/pull/3740)
- upgrade tools by [@&#8203;hawkingrei](https://togithub.com/hawkingrei)
in
[https://github.com/bazelbuild/rules_go/pull/3730](https://togithub.com/bazelbuild/rules_go/pull/3730)
- Also take library deps like srcs into account in go context by
[@&#8203;mering](https://togithub.com/mering) in
[https://github.com/bazelbuild/rules_go/pull/3725](https://togithub.com/bazelbuild/rules_go/pull/3725)
- Add go_cross_binary to README by
[@&#8203;jfirebaugh](https://togithub.com/jfirebaugh) in
[https://github.com/bazelbuild/rules_go/pull/3744](https://togithub.com/bazelbuild/rules_go/pull/3744)
- Update `bazel_features` to v1.1.1 by
[@&#8203;fmeum](https://togithub.com/fmeum) in
[https://github.com/bazelbuild/rules_go/pull/3747](https://togithub.com/bazelbuild/rules_go/pull/3747)
- builder: Make paths absolute for stdliblist
([#&#8203;1357](https://togithub.com/bazelbuild/rules_go/issues/1357))
by [@&#8203;zecke](https://togithub.com/zecke) in
[https://github.com/bazelbuild/rules_go/pull/3748](https://togithub.com/bazelbuild/rules_go/pull/3748)
- feat(gopackagesdriver): add base test case for go packages driver by
[@&#8203;JamyDev](https://togithub.com/JamyDev) in
[https://github.com/bazelbuild/rules_go/pull/3743](https://togithub.com/bazelbuild/rules_go/pull/3743)
- Fix bazel query scope not being used by
[@&#8203;rastenis](https://togithub.com/rastenis) in
[https://github.com/bazelbuild/rules_go/pull/3688](https://togithub.com/bazelbuild/rules_go/pull/3688)
- Add support for `xtest` packages in Go Packages Driver by
[@&#8203;JamyDev](https://togithub.com/JamyDev) in
[https://github.com/bazelbuild/rules_go/pull/3750](https://togithub.com/bazelbuild/rules_go/pull/3750)
- upgrade x/tools to 0.15.0 by
[@&#8203;tyler-french](https://togithub.com/tyler-french) in
[https://github.com/bazelbuild/rules_go/pull/3751](https://togithub.com/bazelbuild/rules_go/pull/3751)
- bug fix: parse embeds in files that contain the double quote rune by
[@&#8203;andyscott](https://togithub.com/andyscott) in
[https://github.com/bazelbuild/rules_go/pull/3672](https://togithub.com/bazelbuild/rules_go/pull/3672)
- prepare release 0.43.0 by
[@&#8203;tyler-french](https://togithub.com/tyler-french) in
[https://github.com/bazelbuild/rules_go/pull/3745](https://togithub.com/bazelbuild/rules_go/pull/3745)

#### New Contributors

- [@&#8203;justinwon777](https://togithub.com/justinwon777) made their
first contribution in
[https://github.com/bazelbuild/rules_go/pull/3718](https://togithub.com/bazelbuild/rules_go/pull/3718)
- [@&#8203;BryanDClark](https://togithub.com/BryanDClark) made their
first contribution in
[https://github.com/bazelbuild/rules_go/pull/3734](https://togithub.com/bazelbuild/rules_go/pull/3734)
- [@&#8203;kotlaja](https://togithub.com/kotlaja) made their first
contribution in
[https://github.com/bazelbuild/rules_go/pull/3740](https://togithub.com/bazelbuild/rules_go/pull/3740)
- [@&#8203;rastenis](https://togithub.com/rastenis) made their first
contribution in
[https://github.com/bazelbuild/rules_go/pull/3688](https://togithub.com/bazelbuild/rules_go/pull/3688)
- [@&#8203;andyscott](https://togithub.com/andyscott) made their first
contribution in
[https://github.com/bazelbuild/rules_go/pull/3672](https://togithub.com/bazelbuild/rules_go/pull/3672)

**Full Changelog**:
bazel-contrib/rules_go@v0.42.0...v0.43.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/kreempuff/rules_unreal_engine).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy41OS44IiwidXBkYXRlZEluVmVyIjoiMzcuNTkuOCIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==-->
cgrindel-self-hosted-renovate bot referenced this pull request in cgrindel/bazel-starlib Nov 20, 2023
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [io_bazel_rules_go](https://togithub.com/bazelbuild/rules_go) |
http_archive | minor | `v0.42.0` -> `v0.43.0` |

---

### Release Notes

<details>
<summary>bazelbuild/rules_go (io_bazel_rules_go)</summary>

###
[`v0.43.0`](https://togithub.com/bazelbuild/rules_go/releases/tag/v0.43.0)

[Compare
Source](https://togithub.com/bazelbuild/rules_go/compare/v0.42.0...v0.43.0)

#### Breaking `x/tools` upgrade

This change includes a breaking upgrade to
[golang.org/x/tools](https://pkg.go.dev/golang.org/x/tools)

Please make sure to upgrade `x/tools` to version `v0.15.0` to ensure
compatibility with rules_go's NoGo.

**If you need to use an older version of `x/tools` (`v0.13.0` or
earlier), apply the following patch to `rules_go`**:

[x-tools.patch](https://togithub.com/bazelbuild/rules_go/files/13417624/x-tools.patch)

#### What's Changed

- Test BCR test module on macos_arm64 by
[@&#8203;fmeum](https://togithub.com/fmeum) in
[https://github.com/bazelbuild/rules_go/pull/3715](https://togithub.com/bazelbuild/rules_go/pull/3715)
- update documentation for `0.42.0` release by
[@&#8203;tyler-french](https://togithub.com/tyler-french) in
[https://github.com/bazelbuild/rules_go/pull/3716](https://togithub.com/bazelbuild/rules_go/pull/3716)
- add netrc support to go_download_sdk by
[@&#8203;justinwon777](https://togithub.com/justinwon777) in
[https://github.com/bazelbuild/rules_go/pull/3718](https://togithub.com/bazelbuild/rules_go/pull/3718)
- Temporarily disable Bzlmod explicitly by
[@&#8203;fmeum](https://togithub.com/fmeum) in
[https://github.com/bazelbuild/rules_go/pull/3720](https://togithub.com/bazelbuild/rules_go/pull/3720)
- Fix urls used to get auth in go_download_sdk by
[@&#8203;justinwon777](https://togithub.com/justinwon777) in
[https://github.com/bazelbuild/rules_go/pull/3724](https://togithub.com/bazelbuild/rules_go/pull/3724)
- Include `go.env` in `//go` runfiles by
[@&#8203;fmeum](https://togithub.com/fmeum) in
[https://github.com/bazelbuild/rules_go/pull/3722](https://togithub.com/bazelbuild/rules_go/pull/3722)
- Update arm platform constraint to latest value in bazel. by
[@&#8203;BryanDClark](https://togithub.com/BryanDClark) in
[https://github.com/bazelbuild/rules_go/pull/3734](https://togithub.com/bazelbuild/rules_go/pull/3734)
- Add toolchain param to affected actions by
[@&#8203;kotlaja](https://togithub.com/kotlaja) in
[https://github.com/bazelbuild/rules_go/pull/3740](https://togithub.com/bazelbuild/rules_go/pull/3740)
- upgrade tools by [@&#8203;hawkingrei](https://togithub.com/hawkingrei)
in
[https://github.com/bazelbuild/rules_go/pull/3730](https://togithub.com/bazelbuild/rules_go/pull/3730)
- Also take library deps like srcs into account in go context by
[@&#8203;mering](https://togithub.com/mering) in
[https://github.com/bazelbuild/rules_go/pull/3725](https://togithub.com/bazelbuild/rules_go/pull/3725)
- Add go_cross_binary to README by
[@&#8203;jfirebaugh](https://togithub.com/jfirebaugh) in
[https://github.com/bazelbuild/rules_go/pull/3744](https://togithub.com/bazelbuild/rules_go/pull/3744)
- Update `bazel_features` to v1.1.1 by
[@&#8203;fmeum](https://togithub.com/fmeum) in
[https://github.com/bazelbuild/rules_go/pull/3747](https://togithub.com/bazelbuild/rules_go/pull/3747)
- builder: Make paths absolute for stdliblist
([#&#8203;1357](https://togithub.com/bazelbuild/rules_go/issues/1357))
by [@&#8203;zecke](https://togithub.com/zecke) in
[https://github.com/bazelbuild/rules_go/pull/3748](https://togithub.com/bazelbuild/rules_go/pull/3748)
- feat(gopackagesdriver): add base test case for go packages driver by
[@&#8203;JamyDev](https://togithub.com/JamyDev) in
[https://github.com/bazelbuild/rules_go/pull/3743](https://togithub.com/bazelbuild/rules_go/pull/3743)
- Fix bazel query scope not being used by
[@&#8203;rastenis](https://togithub.com/rastenis) in
[https://github.com/bazelbuild/rules_go/pull/3688](https://togithub.com/bazelbuild/rules_go/pull/3688)
- Add support for `xtest` packages in Go Packages Driver by
[@&#8203;JamyDev](https://togithub.com/JamyDev) in
[https://github.com/bazelbuild/rules_go/pull/3750](https://togithub.com/bazelbuild/rules_go/pull/3750)
- upgrade x/tools to 0.15.0 by
[@&#8203;tyler-french](https://togithub.com/tyler-french) in
[https://github.com/bazelbuild/rules_go/pull/3751](https://togithub.com/bazelbuild/rules_go/pull/3751)
- bug fix: parse embeds in files that contain the double quote rune by
[@&#8203;andyscott](https://togithub.com/andyscott) in
[https://github.com/bazelbuild/rules_go/pull/3672](https://togithub.com/bazelbuild/rules_go/pull/3672)
- prepare release 0.43.0 by
[@&#8203;tyler-french](https://togithub.com/tyler-french) in
[https://github.com/bazelbuild/rules_go/pull/3745](https://togithub.com/bazelbuild/rules_go/pull/3745)

#### New Contributors

- [@&#8203;justinwon777](https://togithub.com/justinwon777) made their
first contribution in
[https://github.com/bazelbuild/rules_go/pull/3718](https://togithub.com/bazelbuild/rules_go/pull/3718)
- [@&#8203;BryanDClark](https://togithub.com/BryanDClark) made their
first contribution in
[https://github.com/bazelbuild/rules_go/pull/3734](https://togithub.com/bazelbuild/rules_go/pull/3734)
- [@&#8203;kotlaja](https://togithub.com/kotlaja) made their first
contribution in
[https://github.com/bazelbuild/rules_go/pull/3740](https://togithub.com/bazelbuild/rules_go/pull/3740)
- [@&#8203;rastenis](https://togithub.com/rastenis) made their first
contribution in
[https://github.com/bazelbuild/rules_go/pull/3688](https://togithub.com/bazelbuild/rules_go/pull/3688)
- [@&#8203;andyscott](https://togithub.com/andyscott) made their first
contribution in
[https://github.com/bazelbuild/rules_go/pull/3672](https://togithub.com/bazelbuild/rules_go/pull/3672)

**Full Changelog**:
bazel-contrib/rules_go@v0.42.0...v0.43.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR is behind base branch, or you tick the
rebase/retry checkbox.

👻 **Immortal**: This PR will be recreated if closed unmerged. Get
[config help](https://togithub.com/renovatebot/renovate/discussions) if
that's undesired.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Renovate
Bot](https://togithub.com/renovatebot/renovate).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi4xMDAuMCIsInVwZGF0ZWRJblZlciI6IjM2LjEwMC4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->

Co-authored-by: Self-hosted Renovate Bot <361546+cgrindel-self-hosted-renovate[bot]@users.noreply.github.enterprise.com>
cgrindel-self-hosted-renovate bot referenced this pull request in cgrindel/rules_swift_package_manager Nov 22, 2023
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [io_bazel_rules_go](https://togithub.com/bazelbuild/rules_go) |
http_archive | minor | `v0.42.0` -> `v0.43.0` |

---

### Release Notes

<details>
<summary>bazelbuild/rules_go (io_bazel_rules_go)</summary>

###
[`v0.43.0`](https://togithub.com/bazelbuild/rules_go/releases/tag/v0.43.0)

[Compare
Source](https://togithub.com/bazelbuild/rules_go/compare/v0.42.0...v0.43.0)

#### Breaking `x/tools` upgrade

This change includes a breaking upgrade to
[golang.org/x/tools](https://pkg.go.dev/golang.org/x/tools)

Please make sure to upgrade `x/tools` to version `v0.15.0` to ensure
compatibility with rules_go's NoGo.

**If you need to use an older version of `x/tools` (`v0.13.0` or
earlier), apply the following patch to `rules_go`**:

[x-tools.patch](https://togithub.com/bazelbuild/rules_go/files/13417624/x-tools.patch)

#### What's Changed

- Test BCR test module on macos_arm64 by
[@&#8203;fmeum](https://togithub.com/fmeum) in
[https://github.com/bazelbuild/rules_go/pull/3715](https://togithub.com/bazelbuild/rules_go/pull/3715)
- update documentation for `0.42.0` release by
[@&#8203;tyler-french](https://togithub.com/tyler-french) in
[https://github.com/bazelbuild/rules_go/pull/3716](https://togithub.com/bazelbuild/rules_go/pull/3716)
- add netrc support to go_download_sdk by
[@&#8203;justinwon777](https://togithub.com/justinwon777) in
[https://github.com/bazelbuild/rules_go/pull/3718](https://togithub.com/bazelbuild/rules_go/pull/3718)
- Temporarily disable Bzlmod explicitly by
[@&#8203;fmeum](https://togithub.com/fmeum) in
[https://github.com/bazelbuild/rules_go/pull/3720](https://togithub.com/bazelbuild/rules_go/pull/3720)
- Fix urls used to get auth in go_download_sdk by
[@&#8203;justinwon777](https://togithub.com/justinwon777) in
[https://github.com/bazelbuild/rules_go/pull/3724](https://togithub.com/bazelbuild/rules_go/pull/3724)
- Include `go.env` in `//go` runfiles by
[@&#8203;fmeum](https://togithub.com/fmeum) in
[https://github.com/bazelbuild/rules_go/pull/3722](https://togithub.com/bazelbuild/rules_go/pull/3722)
- Update arm platform constraint to latest value in bazel. by
[@&#8203;BryanDClark](https://togithub.com/BryanDClark) in
[https://github.com/bazelbuild/rules_go/pull/3734](https://togithub.com/bazelbuild/rules_go/pull/3734)
- Add toolchain param to affected actions by
[@&#8203;kotlaja](https://togithub.com/kotlaja) in
[https://github.com/bazelbuild/rules_go/pull/3740](https://togithub.com/bazelbuild/rules_go/pull/3740)
- upgrade tools by [@&#8203;hawkingrei](https://togithub.com/hawkingrei)
in
[https://github.com/bazelbuild/rules_go/pull/3730](https://togithub.com/bazelbuild/rules_go/pull/3730)
- Also take library deps like srcs into account in go context by
[@&#8203;mering](https://togithub.com/mering) in
[https://github.com/bazelbuild/rules_go/pull/3725](https://togithub.com/bazelbuild/rules_go/pull/3725)
- Add go_cross_binary to README by
[@&#8203;jfirebaugh](https://togithub.com/jfirebaugh) in
[https://github.com/bazelbuild/rules_go/pull/3744](https://togithub.com/bazelbuild/rules_go/pull/3744)
- Update `bazel_features` to v1.1.1 by
[@&#8203;fmeum](https://togithub.com/fmeum) in
[https://github.com/bazelbuild/rules_go/pull/3747](https://togithub.com/bazelbuild/rules_go/pull/3747)
- builder: Make paths absolute for stdliblist
([#&#8203;1357](https://togithub.com/bazelbuild/rules_go/issues/1357))
by [@&#8203;zecke](https://togithub.com/zecke) in
[https://github.com/bazelbuild/rules_go/pull/3748](https://togithub.com/bazelbuild/rules_go/pull/3748)
- feat(gopackagesdriver): add base test case for go packages driver by
[@&#8203;JamyDev](https://togithub.com/JamyDev) in
[https://github.com/bazelbuild/rules_go/pull/3743](https://togithub.com/bazelbuild/rules_go/pull/3743)
- Fix bazel query scope not being used by
[@&#8203;rastenis](https://togithub.com/rastenis) in
[https://github.com/bazelbuild/rules_go/pull/3688](https://togithub.com/bazelbuild/rules_go/pull/3688)
- Add support for `xtest` packages in Go Packages Driver by
[@&#8203;JamyDev](https://togithub.com/JamyDev) in
[https://github.com/bazelbuild/rules_go/pull/3750](https://togithub.com/bazelbuild/rules_go/pull/3750)
- upgrade x/tools to 0.15.0 by
[@&#8203;tyler-french](https://togithub.com/tyler-french) in
[https://github.com/bazelbuild/rules_go/pull/3751](https://togithub.com/bazelbuild/rules_go/pull/3751)
- bug fix: parse embeds in files that contain the double quote rune by
[@&#8203;andyscott](https://togithub.com/andyscott) in
[https://github.com/bazelbuild/rules_go/pull/3672](https://togithub.com/bazelbuild/rules_go/pull/3672)
- prepare release 0.43.0 by
[@&#8203;tyler-french](https://togithub.com/tyler-french) in
[https://github.com/bazelbuild/rules_go/pull/3745](https://togithub.com/bazelbuild/rules_go/pull/3745)

#### New Contributors

- [@&#8203;justinwon777](https://togithub.com/justinwon777) made their
first contribution in
[https://github.com/bazelbuild/rules_go/pull/3718](https://togithub.com/bazelbuild/rules_go/pull/3718)
- [@&#8203;BryanDClark](https://togithub.com/BryanDClark) made their
first contribution in
[https://github.com/bazelbuild/rules_go/pull/3734](https://togithub.com/bazelbuild/rules_go/pull/3734)
- [@&#8203;kotlaja](https://togithub.com/kotlaja) made their first
contribution in
[https://github.com/bazelbuild/rules_go/pull/3740](https://togithub.com/bazelbuild/rules_go/pull/3740)
- [@&#8203;rastenis](https://togithub.com/rastenis) made their first
contribution in
[https://github.com/bazelbuild/rules_go/pull/3688](https://togithub.com/bazelbuild/rules_go/pull/3688)
- [@&#8203;andyscott](https://togithub.com/andyscott) made their first
contribution in
[https://github.com/bazelbuild/rules_go/pull/3672](https://togithub.com/bazelbuild/rules_go/pull/3672)

**Full Changelog**:
bazel-contrib/rules_go@v0.42.0...v0.43.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR is behind base branch, or you tick the
rebase/retry checkbox.

👻 **Immortal**: This PR will be recreated if closed unmerged. Get
[config help](https://togithub.com/renovatebot/renovate/discussions) if
that's undesired.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Renovate
Bot](https://togithub.com/renovatebot/renovate).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi4xMDAuMCIsInVwZGF0ZWRJblZlciI6IjM2LjEwMC4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->

Co-authored-by: Self-hosted Renovate Bot <361546+cgrindel-self-hosted-renovate[bot]@users.noreply.github.enterprise.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants