go/tools/gopackagesdriver: pass Compiler and Arch in DriverResponse #3657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
go/packages is being changed to expect Compiler and Arch in its DriverResponse (see golang.org/cl/516917) because we can't expect the type of the types.Sizes returned by types.Sizes to be types.StdSizes. (The default it uses when Compiler and Arch aren't set is the set of types for gc,amd64, so there's no change in behavior if those fields aren't set, but we should set them. I'd also like to see if we can correctly provide the arch assuming it's not amd64. I left a question in the code asking about that.
fmeum
reviewed
Aug 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
go/packages is being changed to expect Compiler and Arch in its DriverResponse (see golang.org/cl/516917) because we can't expect the type of the types.Sizes returned by types.Sizes to be types.StdSizes. (The default it uses when Compiler and Arch aren't set is the set of types for gc,amd64, so there's no change in behavior if those fields aren't set, but we should set them. I'd also like to see if we can correctly provide the arch assuming it's not amd64. I left a question in the code asking about that.
For #3656