Deprecate legacy action APIs #3172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The asm, compile, cover, and pack actions on go_context are no longer used by rules_go itself and not covered by any tests. Unless there is a very strong use case for them in our user base and someone steps up to contribute test coverage, these are marked for removal in version 0.36.0. This commit `print`s a warning if any of the deprecated actions is invoked. Note: `cover` has already been removed in 0.32.0.
fmeum
force-pushed
the
legacy-actions-deprecation
branch
from
5332e8d to
51ddf60
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The asm, compile, cover, and pack actions on go_context are no longer
used by rules_go itself and not covered by any tests. Unless there is
a very strong use case for them in our user base and someone steps up
to contribute test coverage, these are marked for removal in version
0.36.0.
This commit
prints a warning if any of the deprecated actions isinvoked.
Note:
coverhas already been removed in 0.32.0.Related to #3168