Use output dir for empty packages to be hermetic #3098
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What does this PR do? Why is it needed?
Some packages are not deterministic, rather they have different content hashes when rebuilt. This occurs when rules_go creates an
_empty.go
file to satisfy the compiler. In those cases, the empty file is created in the OS temp dir, which changes across compiler invocations. The path of this file changes the content hash of the resulting package, thus breaking caches and downstream builds.This PR changes the location of this tmp file to the output path of the package, such that it is the same output path across compiler invocations.
Reproduction steps:
Other notes for review
I noted a broad use of tmpdir or workdir within rules_go, and this issue may be prevalent in other conditions. If determinism is a priority, perhaps an audit of tmp dir uses may be warranted.
It would be useful to have a test that validations reproducibility of this kind, but I'm not aware of a good way to structure that type of test.Reproducibility test has been added