Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Fabian Meumertzheim <[email protected]>
  • Loading branch information
sluongng and fmeum authored Jun 28, 2022
1 parent 9e4f252 commit de2e090
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions go/tools/builders/compilepkg.go
Original file line number Diff line number Diff line change
Expand Up @@ -405,10 +405,10 @@ func compileArchive(
outFactsPath := filepath.Join(workDir, nogoFact)
nogoSrcs := make([]string, 0, len(goSrcs))
for _, goSrc := range goSrcs {
// If source is found in the origin map, that means it's likely to be generated source file
// If source is found in the origin map, that means it's likely to be a generated source file
// so feed the original source file to static analyzers instead of the generated one.
//
// If origin being empty, that means the generated source file has no origin (genrated by rules_go)
// If origin is empty, that means the generated source file is not based on a user-provided source file
// thus ignore that entry entirely.
if originSrc, ok := nogoSrcsOrigin[goSrc]; ok {
if originSrc != "" {
Expand Down
2 changes: 1 addition & 1 deletion tests/core/nogo/coverage/README.rst
Original file line number Diff line number Diff line change
Expand Up @@ -19,5 +19,5 @@ Verifies `#2146`_.

gen_code_test
-------------
Checks how `nogo`_ shoudl not interact with source code that was generated as part of
Checks how `nogo`_ should not run on source code that was generated as part of
rules_go's coverage implementation.

0 comments on commit de2e090

Please sign in to comment.