Fix main_class error in java_fuzz_test
#236
Conversation
In certain situations, `java_fuzz_test`s failed with ``` ERROR: Projects/fuzz-sample/BUILD:3:15: in java_binary rule //:JavaFuzzTest_metadata_: need at least one of 'main_class' or Java source files ERROR: Projects/fuzz-sample/BUILD:3:15: in java_binary rule //:JavaFuzzTest_metadata_: main_class was not provided and cannot be inferred: source path doesn't include a known root (java, javatests, src, testsrc) ERROR: Projects/fuzz-sample/BUILD:3:15: Analysis of target '//:JavaFuzzTest_metadata_' failed ``` This is fixed by marking the metadata jar as non-executable.
fmeum
requested review from
asraa,
inferno-chromium,
fniksic,
oliverchang,
stefanbucur and
xinhaoyuan
as code owners
|
@stefanbucur I just noticed that https://github.com/bazelbuild/rules_fuzzing/actions/workflows/bazel_test.yml has a warning saying "This scheduled workflow is disabled because there hasn't been activity in this repository for at least 60 days. Enable this workflow to resume scheduled runs." You should be able to just reeanble it there. |
|
Thanks for the quick fix! |
Oh wow, nice catch! I've just reenabled the workflow plus another one that was disabled. Not sure what exactly happened there, I don't recall disabling any workflow... |
|
@stefanbucur Glad that it works now, this should make our lives much easier. Could you perhaps create a patch release with this change, ideally with a release archive? |
Great!
Ack! Caught up with lots of work, but will get to it later this week. |
|
@stefanbucur Friendly ping :-) |
|
Should be done now! Let me know if you have trouble with the release archive - hopefully I got the setup right. |
In certain situations,
java_fuzz_tests failed withThis is fixed by marking the metadata jar as non-executable.
Fixes #235