Fix native library handling #195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmeum
force-pushed
the
fix-native-library-path-escaping
branch
from
37545fd to
41cb220
Compare
|
This PR fixes the underlying issue in the @stefanbucur The bug is only relevant when fuzzing Java mixed with native libraries. If that's not super urgent to fix, you could hold the 0.3.1 release until I have fixed this Bazel 5 issue. Otherwise, feel free to cherry-pick the first commit. |
fmeum
force-pushed
the
fix-native-library-path-escaping
branch
2 times, most recently
from
223c5a3 to
2426e3c
Compare
This should have been changed when Jazzer was updated past CodeIntelligenceTesting/jazzer@24069c3 but was missed due to missing test coverage for the case of multiple native libraries. When Bazel 5 was released today, the use of transitions coupled with bazelbuild/bazel@20061f8 caused the NativeFuzzTest example to suddenly have two native library dependencies, which triggered the dormant bug.
transitive_native_libraries can contain LibraryToLink instances for static libraries and object files, which do not have to be added to the java.library.path. Prevent analysis time failures by skipping them.
fmeum
force-pushed
the
fix-native-library-path-escaping
branch
from
2426e3c to
0669d72
Compare
fmeum
changed the title
fmeum
force-pushed
the
fix-native-library-path-escaping
branch
3 times, most recently
from
d6ad7a2 to
581c350
Compare
fmeum
requested review from
asraa,
inferno-chromium,
markus-kusano,
oliverchang,
stefanbucur and
xinhaoyuan
as code owners
|
@stefanbucur This is ready for review now and fixes the two bugs I am aware of. |
stefanbucur
approved these changes
Jan 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See the individual commit messages.