Support UBSan for local fuzzing #187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmeum
requested review from
asraa,
inferno-chromium,
markus-kusano,
oliverchang,
stefanbucur and
xinhaoyuan
as code owners
stefanbucur
requested changes
Nov 29, 2021
fmeum
force-pushed
the
ubsan
branch
2 times, most recently
from
9d92f34 to
8d663cc
Compare
|
I addressed your changes and expanded some of the comments. |
With Jazzer supporting full UBSan as of CodeIntelligenceTesting/jazzer#169 as well as a much simpler way to link the UBSan C++ runtime via the flag used in bazel-contrib#186, UBSan can now be supported in local mode without introducing additional complexity. The list of enabled UBSan checks is taken from OSS-Fuzz. The commit also adds tests to verify that both C++ and Java fuzz tests support the UBSan C++ checks without linker errors.
stefanbucur
approved these changes
Dec 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With Jazzer supporting full UBSan as of CodeIntelligenceTesting/jazzer#169 as well as a much simpler way to link the UBSan C++ runtime via the flag used in #186, UBSan can now be supported in local mode without introducing additional complexity.
The list of enabled UBSan checks is taken from OSS-Fuzz.
The commit also adds tests to verify that both C++ and Java fuzz tests support the UBSan C++ checks without linker errors.