Add bzlmod support files. #999
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsharpe
force-pushed
the
bzlmod
branch
2 times, most recently
from
b47e0be to
37248c6
Compare
jheaff1
reviewed
Apr 24, 2023
| @@ -54,6 +54,19 @@ tasks: | |||
| - "//:third_party_examples_linux_tests" | |||
| build_targets: *linux_targets | |||
| test_targets: *linux_targets | |||
| ubuntu2004_examples_bzlmod: | |||
| name: Examples (bzlmod) | |||
There was a problem hiding this comment.
No MacOS or windows builds?
There was a problem hiding this comment.
Most of the issues with bzlmod specific issues happen at analysis time; I initially have just left this scoped to linux just for the sake of keeping CI times down as macOS in particular is slow.
jheaff1
approved these changes
May 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds configuration for publish-to-bcr app and adds the bzlmod files used in the existing BCR entry.