Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix pkgconfig built by MSVC on Windows #992

Merged
merged 1 commit into from
Feb 21, 2023
Merged

Fix pkgconfig built by MSVC on Windows #992

merged 1 commit into from
Feb 21, 2023

Conversation

jsharpe
Copy link
Member

@jsharpe jsharpe commented Jan 3, 2023

No description provided.

@jsharpe jsharpe enabled auto-merge (squash) January 3, 2023 11:11
@jheaff1
Copy link
Collaborator

jheaff1 commented Feb 21, 2023

Now that the main branch is building ok in CI (hopefully), I can rebase this PR off of main, but its from your fork of this repo so I don't have permission to. Is there a way i can help?

@jsharpe
Copy link
Member Author

jsharpe commented Feb 21, 2023

Now that the main branch is building ok in CI (hopefully), I can rebase this PR off of main, but its from your fork of this repo so I don't have permission to. Is there a way i can help?

Do you want to become a maintainer on this repo? Your contributions have been valuable and @UebelAndre and myself have limited time so an extra pair of hands would be useful!

@jsharpe jsharpe merged commit 4d4a678 into bazel-contrib:main Feb 21, 2023
@jsharpe jsharpe deleted the msvc_pkgconfig branch February 21, 2023 11:44
@jheaff1
Copy link
Collaborator

jheaff1 commented Feb 21, 2023

Now that the main branch is building ok in CI (hopefully), I can rebase this PR off of main, but its from your fork of this repo so I don't have permission to. Is there a way i can help?

Do you want to become a maintainer on this repo? Your contributions have been valuable and @UebelAndre and myself have limited time so an extra pair of hands would be useful!

Sure I'll happily be a maintainer. One caveat, my first baby was due yesterday, she still hasn't arrived yet, so the time I can spend on this repo will be limited for some time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jsharpe @jheaff1