Add meson support #986
Add meson support #986
Conversation
jheaff1
force-pushed
the
add_meson_support_tidy
branch
12 times, most recently
from
4fead53 to
bd7a6a5
Compare
jheaff1
force-pushed
the
add_meson_support_tidy
branch
18 times, most recently
from
7d0d4f7 to
52414a8
Compare
|
|
jheaff1
force-pushed
the
add_meson_support_tidy
branch
5 times, most recently
from
70b4498 to
2c1b87f
Compare
Because you asked so nicely... :) @jsharpe CI is now building, could you please re-review? |
jheaff1
force-pushed
the
add_meson_support_tidy
branch
from
2c1b87f to
403b4a1
Compare
|
Wowie wowie. Thank you! |
There was a problem hiding this comment.
@jheaff1 this is a mammoth effort! Thanks for all the work you've put into this, including all the previous bits that have built up to this in previous PRs that we've already landed!
Just one doc string that needs updating about meson_version but otherwise this LGTM.
A few observations but nothing that needs to block landing this; they can be addressed after this lands.
| @@ -39,6 +39,7 @@ configure_make( | |||
| "--without-docbook", | |||
| "--without-examples", | |||
| "--without-tests", | |||
| "CFLAGS='-fPIC'", | |||
There was a problem hiding this comment.
I don't love that this is required. Does features=["pic"] work for this?
There was a problem hiding this comment.
I tried features=["pic"] and -fPIC was not added to the compiler command line args :(
jheaff1
force-pushed
the
add_meson_support_tidy
branch
2 times, most recently
from
527b017 to
0c8aa89
Compare
This commit adds the glib library to the "examples" build. glib requires pcre2, so pcre and libgit2 (a dependent of pcre) have been updated/modified
This commit adds mesa to the "examples" build. This commit also changes the "examples" build to use the hermetic python toolchain provided by rules_foreign_cc. As such, the python toolchain built by rules_foreign_cc is no longer used, as it cannot be used in workspace rules, .e.g pip_parse(). As such, the python2 build has been removed from the examples as python2 is end-of-life. Until Bazel 4.2.0, the built-in android toolchain required Python 2. As such the minimum supported version has been upversioned to 4.2.0. Note that the BAZEL_VC env var was removed from CI as mesa requires MSVC 2019.
Note that a newer version of pkgconfig than that installed in ubuntu 20 must be used to build libxau, therefore the built_pkgconfig_toolchain is now registered
jheaff1
force-pushed
the
add_meson_support_tidy
branch
from
0c8aa89 to
fcab3af
Compare
Thank you very much. It only took me a year... 🤣. And thanks for your help with reviewing! |
|
Awesome work @jheaff1! |
|
Whoop! Thanks!! 🎉 |
|
Hello, is meson supported today? I plan to use it to compile https://github.com/systemd/systemd |
This PR already added a Meson example: |
|
Mesa is also built using meson: https://github.com/bazel-contrib/rules_foreign_cc/tree/main/examples/third_party/mesa |
This PR adds Meson support to rules_foreign_cc.
This PR depends on #987
This PR is rather large, I tried to make the commits atomic but I can split up the PR into smaller ones if need be.