Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify path to sed on MacOS and FreeBSD #961

Merged
merged 4 commits into from
May 10, 2023
Merged

Conversation

garymm
Copy link
Contributor

@garymm garymm commented Aug 30, 2022

The given commands are not portable between BSD sed and GNU sed.
Some users (at least me) have their PATH such that sed resolves to a
sed that is not default for their OS, and then the given command fails.

The given commands are not portable between BSD sed and GNU sed.
Some users (at least me) have their PATH such that `sed` resolves to a
sed that is not default for their OS, and then the given command fails.
@garymm
Copy link
Contributor Author

garymm commented Aug 30, 2022

Note I didn't update windows because I'm not sure if /usr/bin/sed works on Windows and I can't easily test it.

Copy link
Member

@jsharpe jsharpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies for the delay in getting this reviewed; can you provide a reference that the BSD path is correct? I reverted the linux change as its not correct on all distros.

@jsharpe jsharpe enabled auto-merge (squash) May 10, 2023 16:00
@jsharpe jsharpe merged commit 12ecb04 into bazel-contrib:main May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants