Add ability to specify DLL dir #939
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jheaff1
force-pushed
the
separate_dll_dir
branch
from
f86fdb3 to
b67a6aa
Compare
C/C++ projects typically install DLLs in the "bin" folder and the associated interface library in the "lib" folder. This commit changes the default behaviour accordingly.
jheaff1
force-pushed
the
separate_dll_dir
branch
from
b67a6aa to
a88f5db
Compare
|
@jsharpe @UebelAndre Any chance of of a review? |
jsharpe
approved these changes
Jul 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
C/C++ projects typically install DLLs in the "bin" folder and the
associated interface library in the "lib" folder. This commit changes
the default behaviour accordingly.
The now redundant postfix script in the cmake_hello_world_lib shared test has been removed. The test was also previously broken as no interface library was generated. This commit resolves that issue