Hermetic ninja build #935
Merged
Hermetic ninja build #935
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jheaff1
force-pushed
the
hermetic_ninja_build_tidy
branch
2 times, most recently
from
265275a to
c3a53d1
Compare
This allows for a hermetic build of ninja by using a hermetic python toolchain, like the one provided by the python_register_toolchains macro in rules_python.
auto-merge was automatically disabled
June 23, 2022 07:58
Head branch was pushed to by a user without write access
jheaff1
force-pushed
the
hermetic_ninja_build_tidy
branch
from
c3a53d1 to
2e639e3
Compare
No probs. I've rebased off the main branch 👍 |
jsharpe
approved these changes
Jun 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use python toolchain when building ninja
This allows for a hermetic build of ninja by using a hermetic python
toolchain, like the one provided by the python_register_toolchains macro
in rules_python.