Do not set user defined env variables twice for (c)make #860
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@garrettkajmowicz-sophos Could you check whether this fixes the issue for you? It does in my tests, which will be part of a follow-up PR. |
|
This does address the issue. |
jsharpe
approved these changes
Jan 26, 2022
auto-merge was automatically disabled
February 1, 2022 23:16
Head branch was pushed to by a user without write access
fmeum
force-pushed
the
857-deduplicate-env-vars
branch
from
c8cd180 to
5a18138
Compare
|
@jsharpe Sorry, I missed that this became out of date. Rebased onto main. |
jsharpe
approved these changes
Feb 1, 2022
|
@jsharpe This PR's GitHub Action run got hit by the GitHub archive checksum change, see bazel-contrib/SIG-rules-authors#11 (comment) for context. Could you rerun the pipeline so that this PR will be auto-merged? |
|
I don't have the permissions to rerun the pipeline in buildkite. You'll need to push a trivial change to retrigger it. |
These variables are already exported in the build script prelude and thus don't have to be set on individual make commands.
auto-merge was automatically disabled
February 8, 2022 21:48
Head branch was pushed to by a user without write access
fmeum
force-pushed
the
857-deduplicate-env-vars
branch
from
5a18138 to
8b8adf5
Compare
|
@jsharpe Done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These variables are already exported in the build script prelude and thus don't have to be set on individual make commands.
Resolves an undesired side effect of f61ce5d, that however should not have resulted in this kind of breakage.
Workaround for #857, the fix for the underlying issue will be submitted as a separate PR.