Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support propagation of includes #826

Merged
merged 2 commits into from
Dec 4, 2021
Merged

Support propagation of includes #826

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
90bd6fe
Support propagation of `includes`
ericastor Dec 2, 2021
1c4c14a
Merge branch 'main' into main
jsharpe Dec 4, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion foreign_cc/private/framework.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,6 +108,14 @@ CC_EXTERNAL_RULE_ATTRIBUTES = {
"Variables containing `PATH` (e.g. `PATH`, `LD_LIBRARY_PATH`, `CPATH`) entries will be prepended to the existing variable."
),
),
"includes": attr.string_list(
doc = (
"Optional list of include dirs to be passed to the dependencies of this library. " +
"They are NOT passed to the compiler, you should duplicate them in the configuration options."
),
mandatory = False,
default = [],
),
"lib_name": attr.string(
doc = (
"Library name. Defines the name of the install directory and the name of the static library, " +
Expand Down Expand Up @@ -876,7 +884,10 @@ def _get_headers(compilation_info):
def _define_out_cc_info(ctx, attrs, inputs, outputs):
compilation_info = cc_common.create_compilation_context(
headers = depset([outputs.out_include_dir]),
system_includes = depset([outputs.out_include_dir.path]),
system_includes = depset([outputs.out_include_dir.path] + [
outputs.out_include_dir.path + "/" + include
for include in attrs.includes
]),
includes = depset([]),
quote_includes = depset([]),
defines = depset(attrs.defines),
Expand Down