Add flags from copts and linkopts attributes #796
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmeum
force-pushed
the
fix-copts-linkopts
branch
3 times, most recently
from
8aafae2 to
931905c
Compare
|
@UebelAndre I added unittest coverage to this PR. Could you review and merge it before #777? That would make it much easier to add a proper integration test for #777. |
Without this commit, the copts and linkopts attributes on rules such as make and cmake did not actually add any flags to the foreign build system. The existing standard_cxx_flags_test is expanded to cover this behavior.
fmeum
force-pushed
the
fix-copts-linkopts
branch
from
931905c to
4f694f5
Compare
UebelAndre
approved these changes
Oct 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this commit, the copts and linkopts attributes on rules such as make and cmake did not actually add any flags to the foreign build system.
This is similar to #777 and another place where, as far as I can tell, user-supplied flags were silently swallowed.
coptsis being used in https://github.com/bazelbuild/rules_foreign_cc/blob/a7105dafb067c785cc9ade2c70b0d0ce967490fc/foreign_cc/private/cc_toolchain_util.bzl#L224 but that function always returns an empty dictionary for me. @UebelAndre Do you know how this relates to https://github.com/bazelbuild/rules_foreign_cc/blob/a7105dafb067c785cc9ade2c70b0d0ce967490fc/foreign_cc/private/cc_toolchain_util.bzl#L287 which seems much more feature complete?