Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix building without sandboxing #769

Merged

Conversation

keith
Copy link
Member

@keith keith commented Aug 20, 2021

Since 466c32c any changes you made
while testing rules_foreign_cc, or changes to those rules, would not
invalidate the CMakeCache.txt and lead to build issues. It wasn't the
case before that because new temp dirs were used each time.

@keith
Copy link
Member Author

keith commented Aug 20, 2021

cc @attilaolah @scele

@keith keith mentioned this pull request Aug 20, 2021
@keith keith force-pushed the ks/fix-building-without-sandboxing branch from 10186cf to 4587f08 Compare August 20, 2021 04:18
Since 466c32c any changes you made
while testing rules_foreign_cc, or changes to those rules, would not
invalidate the CMakeCache.txt and lead to build issues. It wasn't the
case before that because new temp dirs were used each time.
@keith keith force-pushed the ks/fix-building-without-sandboxing branch from 4587f08 to f8c5e10 Compare August 20, 2021 04:56
Copy link
Member

@jsharpe jsharpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for finding this issue!

@jsharpe jsharpe merged commit 4ee863c into bazel-contrib:main Aug 20, 2021
@keith keith deleted the ks/fix-building-without-sandboxing branch September 21, 2021 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants