Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated examples to use Visual Studio 2019 #766

Closed
wants to merge 6 commits into from

Conversation

UebelAndre
Copy link
Collaborator

This also tracks the resolution of bazelbuild/continuous-integration#1204. If this PR turns green then that issue is considered resolved.

@homuler
Copy link

homuler commented Dec 19, 2021

I'm sorry if you already know how to resolve the build error.
I'm not sure because I can't test it in the same environment, but I think you also need to overwrite BAZEL_VC, because the path to VS2017 is set to it now.

BAZEL_VC=(C:\Program Files (x86)\Microsoft Visual Studio\2017\BuildTools\VC)

@github-actions
Copy link

This Pull Request has been automatically marked as stale because it has not had any activity for 180 days. It will be closed if no further activity occurs in 30 days. Collaborators can add an assignee to keep this open indefinitely. Thanks for your contributions to rules_foreign_cc!

@jsharpe jsharpe enabled auto-merge (squash) October 14, 2023 14:36
@UebelAndre UebelAndre closed this Dec 25, 2023
auto-merge was automatically disabled December 25, 2023 20:13

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants