-
Notifications
You must be signed in to change notification settings - Fork 248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed make_commands
attribute and fixed configure_make
#671
Conversation
I think as part of this change I should also add an example of how to have a custom make binary to replace, what seems like, a common pattern where users use This comment describes such an approach but I'm not sure if it encompasses enough of the functionality. |
I think #676 would solve for this in a way that makes transitioning easier since it doesn't require users to setup a toolchain |
This PR is blocked until #676 is resolved |
5e14552
to
cd2b5d5
Compare
Cool, this is unblocked now! By the way, once this gets merged, and now that #676 is merged too, it would be really handy to have a new release :) |
@attilaolah This one is ready for review. Let me know if it solves the last issue you're having. |
I'll probably have some timet o take a look at this later today. Running some build tests now to make sure that I have a clean/passing build before patching in this one. |
OK I patched in this change, and all my builds still pass, and the |
Attributes which encourage users to write raw bash are generally non-hermetic and lead to a bunch of difficult edge cases to account for. The
targets
attribute is far more desirable since it allows the rules to provide stable and consistent APIs across all the rules.Additionally, this change fixes an inconsistency with
configure_make
where the targets API was not being used.closes #670