Restrict use of use_default_shell_env to windows.
#647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UebelAndre
force-pushed
the
shell_env
branch
4 times, most recently
from
f3a8132 to
268e54f
Compare
jsharpe
requested changes
May 17, 2021
foreign_cc/private/framework.bzl
Outdated
Comment on lines
265
to
269
| env = dict(ctx.configuration.default_shell_env) | ||
|
|
||
| # Add all environment variables from the cc_toolchain | ||
| cc_env = _correct_path_variable(get_env_vars(ctx)) | ||
| env.update(cc_env) |
There was a problem hiding this comment.
Is this the same way that the environment gets overridden for the native cc_* rules? I would guess that the behaviour is the opposite way around i.e. action_env overrides variables defined by the toolchain but 🤷
There was a problem hiding this comment.
Yeah, action_env should probably take precedence. I'll update this.
Co-authored-by: James Sharpe <[email protected]>
jsharpe
approved these changes
May 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The primary intent of this change is to have a more structured way of controlling the environment. The way it's currently implemented adds support for --action_env to MacOS platforms and adds a centralized place in code to manage environment variables.