configure_in_place make a copy of the source code #596
Conversation
Yes I'll come up with an example that modifies the inputs in its configure script. |
jsharpe
force-pushed
the
configure_in_place
branch
from
2397c10 to
79f6558
Compare
jsharpe
force-pushed
the
configure_in_place
branch
from
a6f420b to
62efa2f
Compare
| # Note that perl -i would just replace the symlink | ||
| # if used directly | ||
|
|
||
| perl -i -pe 's/42/0/' $(readlink src/simple.c) |
There was a problem hiding this comment.
perl?! 😅 Does this work in RBE?
There was a problem hiding this comment.
It appears to! I'd default to sed but then I'd need to branch on os in the configure script to pass the correct arguments (or live with the extra src/simple.c-e file that would be created on macOS).
Unfortunately this example is still not breaking (it does with --spawn_strategy=standalone though)
jsharpe
force-pushed
the
configure_in_place
branch
from
5bc240c to
31216dc
Compare
…es are modified in the source tree by configure
|
This Pull Request has been automatically marked as stale because it has not had any activity for 180 days. It will be closed if no further activity occurs in 30 days. Collaborators can add an assignee to keep this open indefinitely. Thanks for your contributions to rules_foreign_cc! |
|
This PR was automatically closed because it went 30 days without a reply since it was labeled "Can Close?" |
When using configure_in_place make a copy of the source code rather than symlinking as the configure script may modify the input source tree which shouldn't be modified.