Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved more toolchain related rules into ./toolchains #541

Merged
merged 2 commits into from
Mar 11, 2021

Conversation

UebelAndre
Copy link
Collaborator

@UebelAndre UebelAndre commented Mar 3, 2021

This moves toolchain definitions from //tools/build_defs to //toolchains

This also introduces a new package //foreign_cc which now houses the implementation for "built-tool" rules in //foreign_cc/built_tools.

This makes the repo more aligned with the architecture details described in ARCHITECTURE.md

@UebelAndre UebelAndre force-pushed the toolchain branch 8 times, most recently from 30f92c3 to 80882ea Compare March 10, 2021 15:28
@UebelAndre UebelAndre requested a review from jsharpe March 10, 2021 15:32
@UebelAndre UebelAndre marked this pull request as ready for review March 10, 2021 15:32
@UebelAndre UebelAndre requested a review from oquenchil as a code owner March 10, 2021 15:32
@UebelAndre UebelAndre merged commit 43a4335 into bazel-contrib:main Mar 11, 2021
@UebelAndre UebelAndre deleted the toolchain branch March 11, 2021 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants