Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace references to @bazel_tools//platforms with @platforms// #427

Merged
merged 2 commits into from
Jan 23, 2021

Conversation

attilaolah
Copy link
Contributor

The former has been deprecated and will break by --incompatible_use_platforms_repo_for_constraints, as announced in
bazelbuild/bazel#8622.

Fixes #354.

@attilaolah attilaolah marked this pull request as ready for review September 16, 2020 10:44
@attilaolah attilaolah changed the title Replace references to @bazel_tools//platforms with @platforms//. Replace references to @bazel_tools//platforms with @platforms// Sep 17, 2020
@attilaolah

This comment has been minimized.

attilaolah pushed a commit to attilaolah/wasm that referenced this pull request Jan 21, 2021
The former has been deprecated and will break by
--incompatible_use_platforms_repo_for_constraints, as announced in
bazelbuild/bazel#8622.

Fixes bazel-contrib#354.
attilaolah pushed a commit to attilaolah/wasm that referenced this pull request Jan 23, 2021
This includes 75e74567c76fa0dabf4cc5752af3b7cee7689704 and updates for
rebased pull requests:

- bazel-contrib/rules_foreign_cc#427
- bazel-contrib/rules_foreign_cc#428
@UebelAndre UebelAndre merged commit ec690c5 into bazel-contrib:master Jan 23, 2021
@UebelAndre
Copy link
Collaborator

Thanks for updating this! 🙏 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flag --incompatible_use_platforms_repo_for_constraints will break rules_foreign_cc in Bazel 1.2.1
2 participants