fix: let 'toolchain' attr be selectable #1321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The toolchain attr is not currently selectable making builds that need to handle multiple platforms (incl windows) very verbose. The target needs to be declared at least twice, once for windows and once for unix based platforms. By making it selectable, even though we still need a rule() and rule_variant() declaration, we can wrap it in a macro and only expose the macro to the user.
jsun-splunk
force-pushed
the
jsun-fix-selectable-toolchain
branch
from
30a378b to
d7a3ff9
Compare
jsharpe
approved these changes
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The toolchain attr is not currently selectable making builds that need to handle multiple platforms (incl windows) very verbose. The target needs to be declared at least twice, once for windows and once for unix based platforms.
By making it selectable, even though we still need a rule() and rule_variant() declaration, we can wrap it in a macro and only expose the macro to the user.