Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: GH checks fail checksum when downloading glib #1318

Closed

Conversation

jjmaestro
Copy link
Contributor

@jjmaestro
Copy link
Contributor Author

So using a "mirror" for the glib library... fails to build... that's amazing 😅

@jsharpe is there an easy way to test the glib example locally? I'm not able to find a way to run the test in my MacOS and/or Linux setup to try and debug what's going on.

@jjmaestro
Copy link
Contributor Author

jjmaestro commented Nov 7, 2024

Looking at the output of the build that fails, I saw

https://buildkite.com/bazel/rules-foreign-cc/builds/6149#01930305-429e-47f2-a846-89eb93e5fcad/246-533

Initialized empty Git repository in (...)/rules_foreign_cc_examples/external/glib/subprojects/gvdb/.git/
fatal: unable to access 'https://gitlab.gnome.org/GNOME/gvdb.git/': Could not resolve host: gitlab.gnome.org

and looking at a diff of the extracted release artifacts (GH's .tar.gz VS GNOME's tar.xz) lo and behold...

glib $ diff -brauN GNOME/glib-2.77.0/ GH/glib-2.77.0/ | grep '^diff'
diff -brauN GNOME/glib-2.77.0/subprojects/gvdb/COPYING GH/glib-2.77.0/subprojects/gvdb/COPYING
diff -brauN GNOME/glib-2.77.0/subprojects/gvdb/README.md GH/glib-2.77.0/subprojects/gvdb/README.md
diff -brauN GNOME/glib-2.77.0/subprojects/gvdb/gvdb/gvdb-builder.c GH/glib-2.77.0/subprojects/gvdb/gvdb/gvdb-builder.c
diff -brauN GNOME/glib-2.77.0/subprojects/gvdb/gvdb/gvdb-builder.h GH/glib-2.77.0/subprojects/gvdb/gvdb/gvdb-builder.h
diff -brauN GNOME/glib-2.77.0/subprojects/gvdb/gvdb/gvdb-format.h GH/glib-2.77.0/subprojects/gvdb/gvdb/gvdb-format.h
diff -brauN GNOME/glib-2.77.0/subprojects/gvdb/gvdb/gvdb-reader.c GH/glib-2.77.0/subprojects/gvdb/gvdb/gvdb-reader.c
diff -brauN GNOME/glib-2.77.0/subprojects/gvdb/gvdb/gvdb-reader.h GH/glib-2.77.0/subprojects/gvdb/gvdb/gvdb-reader.h
diff -brauN GNOME/glib-2.77.0/subprojects/gvdb/gvdb.doap GH/glib-2.77.0/subprojects/gvdb/gvdb.doap
diff -brauN GNOME/glib-2.77.0/subprojects/gvdb/meson.build GH/glib-2.77.0/subprojects/gvdb/meson.build

and

glib $ ls -l GNOME/glib-2.77.0/subprojects/
total 56
-rw-r--r--@ 1 jjmaestro  wheel  100  7 Jul  2023 gtk-doc.wrap
drwxr-xr-x@ 7 jjmaestro  wheel  224 15 Jun  2022 gvdb
-rw-r--r--@ 1 jjmaestro  wheel  163  7 Jul  2023 gvdb.wrap
-rw-r--r--@ 1 jjmaestro  wheel  147  7 Jul  2023 libffi.wrap
-rw-r--r--@ 1 jjmaestro  wheel  585  7 Jul  2023 pcre2.wrap
-rw-r--r--@ 1 jjmaestro  wheel  136  7 Jul  2023 proxy-libintl.wrap
-rw-r--r--@ 1 jjmaestro  wheel  134  7 Jul  2023 sysprof.wrap
-rw-r--r--@ 1 jjmaestro  wheel  424  7 Jul  2023 zlib.wrap

glib $ ls -l GH/glib-2.77.0/subprojects/   
total 56
-rw-r--r--@ 1 jjmaestro  wheel  100  7 Jul  2023 gtk-doc.wrap
-rw-r--r--@ 1 jjmaestro  wheel  163  7 Jul  2023 gvdb.wrap
-rw-r--r--@ 1 jjmaestro  wheel  147  7 Jul  2023 libffi.wrap
-rw-r--r--@ 1 jjmaestro  wheel  585  7 Jul  2023 pcre2.wrap
-rw-r--r--@ 1 jjmaestro  wheel  136  7 Jul  2023 proxy-libintl.wrap
-rw-r--r--@ 1 jjmaestro  wheel  134  7 Jul  2023 sysprof.wrap
-rw-r--r--@ 1 jjmaestro  wheel  424  7 Jul  2023 zlib.wrap
jjmaestro@macstudio glib %

So my best guess is that the GH release does not contain gvdb. Maybe it can be added as a dependency, like libffi is... I'll see if that's viable and if not... it's quite complicated to build externally, I'd have to check the build against all the platforms, etc.

I'll abandon the PR and will try to figure out what's going on with the download from download.gnome.org that produces a different checksum...

@jjmaestro jjmaestro closed this Nov 7, 2024
@jjmaestro jjmaestro deleted the fix-gnome-download-checksum branch November 20, 2024 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants