Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add foreign_cc deps to cmake prefix path #1311

Merged
merged 1 commit into from
Nov 1, 2024
Merged

add foreign_cc deps to cmake prefix path #1311

merged 1 commit into from
Nov 1, 2024

Conversation

matt-sm
Copy link
Contributor

@matt-sm matt-sm commented Oct 30, 2024

see #887

Rather than creating a new provider, this MR utilizes ForeignCcArtifactInfo:gen_dir to add a $$EXT_BUILD_DEPS/<package> to CMAKE_PREFIX_PATH for each external ForeignCcDepsInfo.

It eliminates the need for custom CMAKE_PREFIX_PATH or <package>_ROOT cache entries on cmake rules.

@matt-sm matt-sm marked this pull request as ready for review October 30, 2024 08:22
jsharpe
jsharpe approved these changes Nov 1, 2024
View reviewed changes
Copy link
Member

@jsharpe jsharpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! This simplifies writing the BUILD files nicely for cmake projects..

@jsharpe jsharpe merged commit 6e54230 into bazel-contrib:main Nov 1, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsharpe jsharpe jsharpe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matt-sm @jsharpe